Make tracing optional & fix CI failure & update CI config #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
error[E0599]: no function or associated item named `from_pid` found for struct `Process` in the current scope
--> src/reactor/kqueue.rs:66:35
|
66 | unsafe { Process::from_pid(*pid, ProcessOps::Exit) },
| ^^^^^^^^ function or associated item not found in `Process<'_>`
|
```
```
error: variables can be used directly in the `format!` string
--> examples/linux-inotify.rs:55:17
|
55 | println!("{:?}", event);
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-D clippy::uninlined-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
55 - println!("{:?}", event);
55 + println!("{event:?}");
|
error: variables can be used directly in the `format!` string
--> benches/io.rs:35:30
|
35 | group.bench_function(format!("TcpStream.{}", driver_name), move |b| {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-D clippy::uninlined-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
35 - group.bench_function(format!("TcpStream.{}", driver_name), move |b| {
35 + group.bench_function(format!("TcpStream.{driver_name}"), move |b| {
|
error: variables can be used directly in the `format!` string
--> benches/io.rs:58:34
|
58 | group.bench_function(format!("UnixStream.{}", driver_name), |b| {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
58 - group.bench_function(format!("UnixStream.{}", driver_name), |b| {
58 + group.bench_function(format!("UnixStream.{driver_name}"), |b| {
|
error: variables can be used directly in the `format!` string
--> benches/io.rs:82:30
|
82 | group.bench_function(format!("TcpStream.{}", driver_name), move |b| {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
82 - group.bench_function(format!("TcpStream.{}", driver_name), move |b| {
82 + group.bench_function(format!("TcpStream.{driver_name}"), move |b| {
|
error: variables can be used directly in the `format!` string
--> benches/io.rs:108:31
|
108 | let socket_addr = format!("/tmp/async-io-bench-{}.sock", id);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
108 - let socket_addr = format!("/tmp/async-io-bench-{}.sock", id);
108 + let socket_addr = format!("/tmp/async-io-bench-{id}.sock");
|
error: variables can be used directly in the `format!` string
--> benches/io.rs:111:34
|
111 | group.bench_function(format!("UnixStream.{}", driver_name), |b| {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
111 - group.bench_function(format!("UnixStream.{}", driver_name), |b| {
111 + group.bench_function(format!("UnixStream.{driver_name}"), |b| {
|
error: variables can be used directly in the `format!` string
--> benches/io.rs:145:30
|
145 | group.bench_function(format!("UdpSocket.{}", driver_name), |b| {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
145 - group.bench_function(format!("UdpSocket.{}", driver_name), |b| {
145 + group.bench_function(format!("UdpSocket.{driver_name}"), |b| {
|
error: variables can be used directly in the `format!` string
--> benches/timer.rs:27:13
|
27 | format!("register_timer.({} previous timers)", prev_timer_count),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-D clippy::uninlined-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
27 - format!("register_timer.({} previous timers)", prev_timer_count),
27 + format!("register_timer.({prev_timer_count} previous timers)"),
|
```
This was referenced Jul 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CI and unblock other PRs.