Require base64-arraybuffer module conditionally. #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since base64-arraybuffer version 0.1.5 introduced a change that fails at require time in a browser without ArrayBuffer support, the require must be guarded.
|
Two Saucelabs failures seem to be because iPhone version 5.1 and 6.1 have disappeared; no tests are run when targeting those versions. |
|
With the increased attention on publishing a new version to include the React Native fix, I'd love to see this merged and in there as part of that, to kill two birds with one stone. Please let me know what you think! |
|
For those who have merge permissions, just a reminder in your inbox about this in case you find yourself with some spare time. |
|
Thanks! |
|
Very much appreciated, Damien. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since base64-arraybuffer version 0.1.5 introduced a change that fails at require time in a browser without ArrayBuffer support, the require must be guarded.
I verified that the existing tests fail on IE 8 once base64-arraybuffer is at 0.1.5 and that they no longer fail after the patch. This ought to help resolve socketio/engine.io#407.