[chore] Use wtf-8 instead of utf8 to prevent lone surrogates from gen… #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erating parsing error
|
I think it would be better to stick with utf8.js and catch the exception. We need to do that anyway because wtf-8 will still throw on other kinds on invalid input. Also, https://simonsapin.github.io/wtf-8/#intended-audience specifically says:
|
|
Any news on when this version will be targeted by socket.io? Currently, socket.io 1.4.8 brings in engine.io-parser 1.2.4, which does not have this fix. I'm having to manually patch my deployments right now because this bug can crash the server if not sanitized. |
darrachequesne
added a commit
to darrachequesne/engine.io-parser
that referenced
this pull request
Oct 16, 2016
…from generating parsing error (socketio#68)" This reverts commit f5d966b.
This was referenced Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erating parsing error
Note: sanitization should occur upfront
Closes #61, fixes (partially) socketio/socket.io#2459