feat: Resolvable guarded compute pipelines #1874
Open
+170
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed-compute-pipelines
|
pkg.pr.new packages benchmark commit |
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the underlying pipeline and sizeUniform properties on TgpuGuardedComputePipeline to enable resolution of guarded compute pipelines. Since tgpu.resolve cannot directly resolve guarded pipelines (which are wrappers), users need access to the inner pipeline for shader code generation.
- Added public getters for
pipelineandsizeUniformonTgpuGuardedComputePipeline - Implemented the getters in
TgpuGuardedComputePipelineImpl - Added comprehensive test coverage for pipeline resolution scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/typegpu/src/core/root/rootTypes.ts | Added JSDoc documentation and type definitions for pipeline and sizeUniform properties on the TgpuGuardedComputePipeline interface |
| packages/typegpu/src/core/root/init.ts | Implemented getter methods for pipeline and sizeUniform in TgpuGuardedComputePipelineImpl class |
| packages/typegpu/tests/pipeline-resolution.test.ts | Added comprehensive test suite covering render pipeline, compute pipeline, guarded compute pipeline resolution, and error handling for multiple pipelines |
| apps/typegpu-docs/src/content/docs/fundamentals/utils.mdx | Added documentation explaining how to access the inner pipeline from a guarded pipeline for use with tgpu.resolve |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
aleksanderkatan
requested review from
cieplypolar,
iwoplaza,
lursz and
reczkok
iwoplaza
reviewed
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided not to make the guarded pipelines resolvable, but to instead expose the underlying pipeline.