Skip to content

Conversation

@softwaremill-ci
Copy link
Contributor

Updates

from 1.3.7 to 1.3.8.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.softwaremill.sttp.shared" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.softwaremill.sttp.shared" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

@mergify mergify bot added the dependency label Sep 2, 2022
@Pask423 Pask423 self-assigned this Sep 2, 2022
@Pask423 Pask423 requested a review from adamw September 4, 2022 18:14
@Pask423
Copy link
Contributor

Pask423 commented Sep 4, 2022

Link to PR with fix for File and Blob APIs in scalajsdom: scala-js/scala-js-dom#721

@adamw
Copy link
Member

adamw commented Sep 4, 2022

So how come updating sttp-shared broke JS code - does this somehow transitively update scala-js? But shouldn't this be in a PR here as well?

@Pask423
Copy link
Contributor

Pask423 commented Sep 4, 2022

Shared 1.3.8 contains this small PR with updates scala-js-dom to 2.3.0 https://github.com/scala-js/scala-js-dom/releases/tag/v2.3.0.
Screenshot 2022-09-04 at 22 07 25

Where JS team make a lot of changes regarding File type (more details in comment above).
Because sttp-core depends on shread this update cause all our logic with js-dom File to fail.
For example:
Screenshot 2022-09-04 at 22 12 16

@adamw
Copy link
Member

adamw commented Sep 5, 2022

Ah it's the scalajs-dom transitive dep. All clear then :) Thanks :)

@adamw adamw merged commit 07e37f3 into master Sep 5, 2022
@mergify mergify bot deleted the update/akka-1.3.8 branch September 5, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants