Skip to content

Add support for practical exam #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 2, 2019
Merged

Add support for practical exam #915

merged 4 commits into from
Sep 2, 2019

Conversation

@geshuming
Copy link
Contributor

@geshuming geshuming commented Sep 2, 2019

Features:

  • New practical assessment tab
    image
  • New icon indicating the assessment is password protected
    image
  • Password is prompted when accessing such assessments
    image

@coveralls
Copy link

coveralls commented Sep 2, 2019

Pull Request Test Coverage Report for Build 3371

  • 2 of 10 (20.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 36.883%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sagas/requests.ts 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
src/sagas/requests.ts 1 22.19%
Totals Coverage Status
Change from base Build 3361: -0.02%
Covered Lines: 2681
Relevant Lines: 6503
💛 - Coveralls

@jiachen247
Copy link
Contributor

jiachen247 commented Sep 2, 2019

LGTM we fix anything later on lol

@jiachen247 jiachen247 merged commit 28a0776 into master Sep 2, 2019
@geshuming geshuming deleted the add-practical-2 branch September 2, 2019 15:23
wltan pushed a commit to Source-Academy-Game/cadet-frontend that referenced this pull request Feb 19, 2020
@geshuming @wltan
Add support for practical exam (source-academy#915)
2f1d1fe 
* Add prompt for password when required

* Add new assessment type: Practical, new private field to assessmentOverview

* Update snapshots

* Fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aulud Aulud Awaiting requested review from Aulud

@jiachen247 jiachen247 Awaiting requested review from jiachen247

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@geshuming @coveralls @jiachen247