Fix playground share links not sharing execution time limit #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Eclmist - saw your simple raytracing program in Source. If possible, can you pull this branch and verify the changes fix the issue? I've tested it locally in the development environment with a few cases and it works as intended for me. Thanks! |
Pull Request Test Coverage Report for Build 3427
💛 - Coveralls |
|
Verified working on my end with no obvious issues or side-effects. Looking good! |
geshuming
approved these changes
Sep 8, 2019
Contributor
|
Don't close issues without the associated PR being merged in. Using keywords like 'Resolves' and "Fixes" will link the PR to the issue and close it automatically when this PR is merged |
wltan
pushed a commit
to Source-Academy-Game/cadet-frontend
that referenced
this pull request
Feb 19, 2020
…cademy#919) * Encode and decode interpreter execution time in playground share links * Fix broken playground saga tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bugfix] Fix playground share links not sharing execution time limit
Summary: Resolves #877 by ensuring the 'Share' button encodes the execution time limit in the output URL.
Changelog
exec(forexecTime) in the generated URLparseExecTimefor parsing theexecfield in shared playground links to anexecTimeto update the Playground workspace withexecparameter is missing or not a number or parsed to a number less than 1000 ms, the default execution time limit of 1000 ms for the Playground is used instead.Last updated 4 Sept 2019, 11:55PM