Skip to content

Add an ability to produce an <ol>...</ol>-wrapped list to display line numbers #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2017
Merged

Add an ability to produce an <ol>...</ol>-wrapped list to display line numbers #21

merged 3 commits into from
May 31, 2017

Conversation

@iafan
Copy link
Contributor

@iafan iafan commented May 30, 2017

This implements #20 using functional parameters:

// default backward-compatible call
got, err := AsHTML(input)

// with optional parameter
got, err := AsHTML(input, OrderedList())

iafan added 3 commits May 30, 2017 10:37
@iafan
Added AsOrdered() option to generate <ol>-wrapped output
a7cd7f9 
This gives an ability to show highlighted source with line numbers.
@iafan
Update README to mention OrderedList() option
056907f
@iafan
An attempt to fix Travis CI builds and add modern Go targets
99fca80 
Reason: `go vet` is no longer go-get-able and is available
as a standard tool since Go 1.6. I think it should be fine to drop
Go 1.4 from test targets for this reason.
@sqs sqs merged commit 190f588 into sourcegraph:master May 31, 2017
@sqs
Copy link
Member

sqs commented May 31, 2017

Thanks!

@dmitshur dmitshur mentioned this pull request May 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iafan @sqs @dmitshur