introduce general musl support #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-434-better-musl-support
branch
2 times, most recently
from
8d4534a to
cbef831
Compare
flavorjones
force-pushed
the
flavorjones-434-better-musl-support
branch
from
cbef831 to
c2eb62a
Compare
This was referenced Jan 23, 2024
Closed
flavorjones
force-pushed
the
flavorjones-434-better-musl-support
branch
11 times, most recently
from
af4d7e5 to
3d5d795
Compare
|
This went green using rake-compiler-dock 1.5.0.rc1! |
|
Found a pretty significant blocker this weekend. We probably cannot release this unless ruby/rubygems#7432 is addressed in bundler or rubygems. And even then, we probably need additional documentation to help people resolve issues. Putting this on hold until we know more. |
kou
pushed a commit
to rake-compiler/rake-compiler
that referenced
this pull request
Jan 30, 2024
…x libc (#236) ### Problem I'm trying to solve Rubygems does not correctly recognize `-musl` or `-gnu` platform suffixes until v3.3.22. ### Solution If rake-compiler is building a linux native gem that specifies a libc in its platform object, then add ">= 3.3.22" to the required_rubygems_version requirement. https://github.com/rubygems/rubygems/blob/master/CHANGELOG.md#3322--2022-09-07 ### Context While working on musl support in the precompilation toolchain: - rake-compiler/rake-compiler-dock#111 - flavorjones/ruby-c-extensions-explained#27 - sparklemotion/sqlite3-ruby#442 - sparklemotion/nokogiri#3111 I noticed that Ruby 3.0 is still shipping with Rubygems 3.2.33, which does not recognize these gem platforms. Specifying the rubygems requirement changes the error experienced by users during gem installation from: > ERROR: While executing gem ... (Gem::Exception) > Unable to find spec for #<Gem::NameTuple rcee_precompiled, 0.6.test.2024.0128.1724, aarch64-linux> to: > ERROR: Error installing rcee_precompiled-0.6.test.2024.0128.1735-x86_64-linux-musl.gem: > rcee_precompiled-0.6.test.2024.0128.1735-x86_64-linux-musl requires RubyGems version >= 3.3.22. > The current RubyGems version is 3.2.33. Try 'gem update --system' to update RubyGems itself.
flavorjones
force-pushed
the
flavorjones-434-better-musl-support
branch
from
3d5d795 to
a8f3f05
Compare
|
Picking this back up again since the fix to the rubygems issue mentioned above was released in bundler 2.5.6. |
flavorjones
force-pushed
the
flavorjones-434-better-musl-support
branch
from
d6048e6 to
7bfc42c
Compare
flavorjones
force-pushed
the
flavorjones-434-better-musl-support
branch
from
7bfc42c to
5325e98
Compare
flavorjones
force-pushed
the
flavorjones-434-better-musl-support
branch
2 times, most recently
from
4ebdd1d to
37e84d7
Compare
|
OK, proceeding carefully here after an exploration revealed some versions of rubygems and bundler aren't going to work well, see rake-compiler/rake-compiler-dock#117 Planning to cut a release candidate this week. |
to reproduce the issue from #434
Rubygems 3.3.22 is the minimum needed to correctly detect and use `-linux-musl` and `-linux-gnu` native gems. rake-compiler/rake-compiler#236 introduced a minimum rubygems version for these native platform gems to provide a sensible error message.
flavorjones
force-pushed
the
flavorjones-434-better-musl-support
branch
from
37e84d7 to
112e479
Compare
updating to rake-compiler-dock 1.5.0
flavorjones
force-pushed
the
flavorjones-434-better-musl-support
branch
from
112e479 to
aba0c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that will remain open while we work on a general fix for musl version issues.
*-linux-muslas a target platform rake-compiler/rake-compiler-dock#75)Fixes #434
Fixes #372