Skip to content

Conversation

@abhishekspeer
Copy link
Contributor

Signed-off-by: abhishekspeer [email protected]

RDF writer support is added via this pull request.

@abhishekspeer abhishekspeer changed the title Add rdfSaver Add rdfSaver Files Aug 16, 2019
@abhishekspeer abhishekspeer force-pushed the master branch 3 times, most recently from 0b39686 to bd20335 Compare August 16, 2019 13:40
Signed-off-by: abhishekspeer <[email protected]>
@abhishekspeer
Copy link
Contributor Author

Hi @swinslow, I've added the code to convert intermediate data structure to standard data structure with this commit. Please have a look and let me know in case you expect any changes
Now completing the code to convert standard data structure into intermediate data data structure. :)

@rtgdk
Copy link

rtgdk commented Aug 17, 2019

@abhishekspeer Open a separate PR for that. Since we want to merge that code with rdf-reader branch and see the reader part running. This PR is just for rdfsaver.

@abhishekspeer
Copy link
Contributor Author

Thanks @rtgdk! I've referenced a separate PR for that. Please have a look and let me know if there is anything I should change. :)

@abhishekspeer abhishekspeer force-pushed the master branch 2 times, most recently from bd5741c to b709a70 Compare August 24, 2019 12:32
@swinslow
Copy link
Member

@abhishekspeer Did you see that the DCO sign-off check is failing? It appears that some of the commits are missing the DCO sign-off (see the "Details" button next to the DCO line in the checks box).

Can you please amend those commits or if necessary squash and re-submit as one commit with the DCO sign-off corrected?

@abhishekspeer
Copy link
Contributor Author

@swinslow I have made the required changes you suggested and DCO passes now. Please let me know if there is anything else I need to change. Thanks! :)

@swinslow
Copy link
Member

Thanks @abhishekspeer!

@swinslow swinslow merged commit 3c5492c into spdx:rdfreader Aug 24, 2019
@swinslow swinslow mentioned this pull request Aug 24, 2019
@swinslow swinslow added this to the 0.1.0 milestone Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants