Skip to content

Conversation

@anatolyshipitz
Copy link
Collaborator

  • Downgraded @eslint/js from version 9.27.0 to 8.57.1.
  • Updated typescript-eslint from version 8.32.1 to 8.33.0.
  • Added new dependencies: @slack/web-api (7.9.2), axios (1.9.0), axios-rate-limit (1.4.0), axios-retry (4.5.0), and mongoose (8.15.1).

These changes ensure compatibility and introduce new functionalities for the project.

- Downgraded @eslint/js from version 9.27.0 to 8.57.1.
- Updated typescript-eslint from version 8.32.1 to 8.33.0.
- Added new dependencies: @slack/web-api (7.9.2), axios (1.9.0), axios-rate-limit (1.4.0), axios-retry (4.5.0), and mongoose (8.15.1).

These changes ensure compatibility and introduce new functionalities for the project.
@anatolyshipitz anatolyshipitz requested a review from killev as a code owner June 2, 2025 16:01
@coderabbitai
Copy link

coderabbitai bot commented Jun 2, 2025

📝 Walkthrough

Walkthrough

The package.json file for the temporal-worker-main project was updated to reorder the @types/node devDependency, upgrade typescript-eslint from 8.32.1 to 8.33.0, and add new runtime dependencies: @slack/web-api, axios, axios-rate-limit, axios-retry, and mongoose. No source code or public API changes were made.

Changes

File(s) Change Summary
workers/main/package.json Reordered @types/node devDependency, upgraded typescript-eslint to 8.33.0, added runtime dependencies: @slack/web-api, axios, axios-rate-limit, axios-retry, and mongoose

Possibly related PRs

  • Update dependencies #29: Updates dependencies in workers/main/package.json, adding different runtime packages and modifying TypeScript config; related by similar dependency management in the same file.

Suggested reviewers

  • killev

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd54824 and e3ca21e.

⛔ Files ignored due to path filters (1)
  • workers/main/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • workers/main/package.json (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • workers/main/package.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Docker Security Scanning (n8n, Dockerfile.n8n, n8n-test:latest)
  • GitHub Check: Service Availability Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Jun 2, 2025

🔍 Vulnerabilities of temporal-test:latest

📦 Image Reference temporal-test:latest
digestsha256:da30eca7154c7c4cb2616e31f7411021ea9146d5b15c68adf2a57df4c52b164c
vulnerabilitiescritical: 2 high: 7 medium: 0 low: 0
platformlinux/amd64
size218 MB
packages358
📦 Base Image alpine:3
also known as
  • 3.21
  • 3.21.3
  • latest
digestsha256:1c4eef651f65e2f7daee7ee785882ac164b02b78fb74503052a26dc061c90474
vulnerabilitiescritical: 0 high: 0 medium: 0 low: 0
critical: 1 high: 0 medium: 0 low: 0 stdlib 1.23.2 (golang)

pkg:golang/[email protected]

critical : CVE--2025--22871

Affected range<1.23.8
Fixed version1.23.8
EPSS Score0.018%
EPSS Percentile3rd percentile
Description

The net/http package improperly accepts a bare LF as a line terminator in chunked data chunk-size lines. This can permit request smuggling if a net/http server is used in conjunction with a server that incorrectly accepts a bare LF as part of a chunk-ext.

critical: 1 high: 0 medium: 0 low: 0 stdlib 1.23.6 (golang)

pkg:golang/[email protected]

critical : CVE--2025--22871

Affected range<1.23.8
Fixed version1.23.8
EPSS Score0.018%
EPSS Percentile3rd percentile
Description

The net/http package improperly accepts a bare LF as a line terminator in chunked data chunk-size lines. This can permit request smuggling if a net/http server is used in conjunction with a server that incorrectly accepts a bare LF as part of a chunk-ext.

critical: 0 high: 1 medium: 0 low: 0 golang.org/x/crypto 0.32.0 (golang)

pkg:golang/golang.org/x/[email protected]

high : CVE--2025--22869

Affected range<0.35.0
Fixed version0.35.0
EPSS Score0.051%
EPSS Percentile16th percentile
Description

SSH servers which implement file transfer protocols are vulnerable to a denial of service attack from clients which complete the key exchange slowly, or not at all, causing pending content to be read into memory, but never transmitted.

critical: 0 high: 1 medium: 0 low: 0 github.com/golang-jwt/jwt 3.2.2+incompatible (golang)

pkg:golang/github.com/golang-jwt/[email protected]%2Bincompatible

high 8.7: CVE--2025--30204 Asymmetric Resource Consumption (Amplification)

Affected range>=3.2.0
<=3.2.2
Fixed versionNot Fixed
CVSS Score8.7
CVSS VectorCVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:H/SC:N/SI:N/SA:N
EPSS Score0.025%
EPSS Percentile5th percentile
Description

Summary

Function parse.ParseUnverified currently splits (via a call to strings.Split) its argument (which is untrusted data) on periods.

As a result, in the face of a malicious request whose Authorization header consists of Bearer followed by many period characters, a call to that function incurs allocations to the tune of O(n) bytes (where n stands for the length of the function's argument), with a constant factor of about 16. Relevant weakness: CWE-405: Asymmetric Resource Consumption (Amplification)

Details

See parse.ParseUnverified

Impact

Excessive memory allocation

critical: 0 high: 1 medium: 0 low: 0 go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc 0.36.4 (golang)

pkg:golang/go.opentelemetry.io/contrib/[email protected]#google.golang.org/grpc/otelgrpc

high 7.5: CVE--2023--47108 Allocation of Resources Without Limits or Throttling

Affected range<0.46.0
Fixed version0.46.0
CVSS Score7.5
CVSS VectorCVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
EPSS Score2.744%
EPSS Percentile85th percentile
Description

Summary

The grpc Unary Server Interceptor opentelemetry-go-contrib/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go

// UnaryServerInterceptor returns a grpc.UnaryServerInterceptor suitable
// for use in a grpc.NewServer call.
func UnaryServerInterceptor(opts ...Option) grpc.UnaryServerInterceptor {

out of the box adds labels

  • net.peer.sock.addr
  • net.peer.sock.port

that have unbound cardinality. It leads to the server's potential memory exhaustion when many malicious requests are sent.

Details

An attacker can easily flood the peer address and port for requests.

PoC

Apply the attached patch to the example and run the client multiple times. Observe how each request will create a unique histogram and how the memory consumption increases during it.

Impact

In order to be affected, the program has to configure a metrics pipeline, use UnaryServerInterceptor, and does not filter any client IP address and ports via middleware or proxies, etc.

Others

It is similar to already reported vulnerabilities.

Workaround for affected versions

As a workaround to stop being affected, a view removing the attributes can be used.

The other possibility is to disable grpc metrics instrumentation by passing otelgrpc.WithMeterProvider option with noop.NewMeterProvider.

Solution provided by upgrading

In PR #4322, to be released with v0.46.0, the attributes were removed.

References

critical: 0 high: 1 medium: 0 low: 0 golang.org/x/oauth2 0.7.0 (golang)

pkg:golang/golang.org/x/[email protected]

high : CVE--2025--22868

Affected range<0.27.0
Fixed version0.27.0
EPSS Score0.063%
EPSS Percentile20th percentile
Description

An attacker can pass a malicious malformed token which causes unexpected memory to be consumed during parsing.

critical: 0 high: 1 medium: 0 low: 0 github.com/golang-jwt/jwt/v4 4.5.1 (golang)

pkg:golang/github.com/golang-jwt/[email protected]#v4

high 8.7: CVE--2025--30204 Asymmetric Resource Consumption (Amplification)

Affected range<4.5.2
Fixed version4.5.2
CVSS Score8.7
CVSS VectorCVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:H/SC:N/SI:N/SA:N
EPSS Score0.025%
EPSS Percentile5th percentile
Description

Summary

Function parse.ParseUnverified currently splits (via a call to strings.Split) its argument (which is untrusted data) on periods.

As a result, in the face of a malicious request whose Authorization header consists of Bearer followed by many period characters, a call to that function incurs allocations to the tune of O(n) bytes (where n stands for the length of the function's argument), with a constant factor of about 16. Relevant weakness: CWE-405: Asymmetric Resource Consumption (Amplification)

Details

See parse.ParseUnverified

Impact

Excessive memory allocation

critical: 0 high: 1 medium: 0 low: 0 c-ares 1.34.3-r0 (apk)

pkg:apk/alpine/[email protected]?os_name=alpine&os_version=3.21

high : CVE--2025--31498

Affected range<1.34.5-r0
Fixed version1.34.5-r0
EPSS Score0.147%
EPSS Percentile36th percentile
Description
critical: 0 high: 1 medium: 0 low: 0 golang.org/x/oauth2 0.26.0 (golang)

pkg:golang/golang.org/x/[email protected]

high : CVE--2025--22868

Affected range<0.27.0
Fixed version0.27.0
EPSS Score0.063%
EPSS Percentile20th percentile
Description

An attacker can pass a malicious malformed token which causes unexpected memory to be consumed during parsing.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
workers/main/package.json (1)

33-41: Evaluate new runtime dependencies
You’ve added @slack/web-api, axios, axios-rate-limit, axios-retry, and mongoose as runtime deps. Please verify:

  1. Each is actually imported/used in the codebase.
  2. No known vulnerabilities exist (npm audit).
  3. The Node.js version in CI/production meets the requirements of Mongoose v8.15.1 and TypeScript v5.8.3.

Consider adding an "engines": { "node": ">=18.0.0" } field to enforce compatibility.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a064ad and cd54824.

⛔ Files ignored due to path filters (1)
  • workers/main/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • workers/main/package.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Docker Security Scanning (n8n, Dockerfile.n8n, n8n-test:latest)
  • GitHub Check: Service Availability Check
🔇 Additional comments (2)
workers/main/package.json (2)

27-27: typescript-eslint patch update looks good
Upgrading from v8.32.1 to v8.33.0 is a non-breaking, patch-level change. No further action required.


11-11:

❓ Verification inconclusive

Potential ESLint plugin/core version mismatch
The @eslint/js package has been downgraded to v8.57.1 while the core eslint remains at v9.27.0. A major‐version mismatch between plugin and core can break linting.

Run this to inspect the peerDependencies for compatibility:


🏁 Script executed:

#!/bin/bash
# Check peerDependencies for @eslint/js v8.57.1
npm view @eslint/[email protected] peerDependencies

Length of output: 45


🏁 Script executed:

#!/bin/bash
# Inspect peerDependencies for @eslint/js v8.57.1 in JSON format
npm view @eslint/[email protected] peerDependencies --json

Length of output: 52


Verify ESLint plugin/core version alignment
The @eslint/js package is pinned at v8.57.1 while the core eslint remains at v9.27.0. A major‐version mismatch between plugin and core can break your linting setup—please confirm compatibility by inspecting the plugin’s peerDependencies or official docs.

• File: workers/main/package.json, line 11
• Run locally to double-check:

npm view @eslint/[email protected] peerDependencies

• Or verify on the npm registry: https://www.npmjs.com/package/@eslint/js

coderabbitai[bot]
coderabbitai bot previously approved these changes Jun 2, 2025
Copy link
Contributor

@killev killev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you reduce ECLint. I don't mind, just need to document

…ge-lock.json

- Updated @eslint/js from version 8.57.1 to 9.27.0 to incorporate the latest features and improvements.
- Adjusted node engine compatibility in package-lock.json to support newer versions.

These changes enhance code quality and maintainability by ensuring the use of the latest ESLint version.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2025

@anatolyshipitz
Copy link
Collaborator Author

The version downgrade was due to a compatibility issue with one of the plugins that is no longer in use.
This is no longer relevant, as both versions are now compatible with the current plugins.

https://typescript-eslint.io/users/dependency-versions#eslint

@anatolyshipitz anatolyshipitz enabled auto-merge (squash) June 2, 2025 16:37
@anatolyshipitz anatolyshipitz requested a review from killev June 2, 2025 16:37
Copy link
Contributor

@killev killev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anatolyshipitz anatolyshipitz merged commit 038274c into main Jun 2, 2025
17 of 18 checks passed
@anatolyshipitz anatolyshipitz deleted the chore/64207-update-dependencies-main-worker branch June 2, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants