Remove group name parameter

[anatolyshipitz]

• Updated the getTargetUnits function and its related repository to no longer require a groupName parameter, streamlining the function's interface.
• Adjusted all corresponding tests to reflect this change, ensuring that the function operates correctly without the group name.
• This refactor enhances the usability of the getTargetUnits function by simplifying its call signature and reducing complexity in the workflow.

These changes improve the maintainability and clarity of the financial reporting process.

[coderabbitai]

📝 Walkthrough

Walkthrough

This change removes the groupName parameter and all related enum/type references from the getTargetUnits function, its repository interface and implementation, the weeklyFinancialReportsWorkflow, and all associated test suites. Calls, validations, and error handling related to groupName are eliminated, simplifying the affected APIs and workflows to operate without this parameter.

Changes

Cohort / File(s)	Change Summary
Remove groupName parameter from workflow and activity workers/main/src/activities/weeklyFinancialReports/getTargetUnits.ts, workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.ts	Removed the groupName parameter from function signatures and internal logic; updated calls to be parameterless.
Repository interface and implementation update workers/main/src/services/TargetUnit/ITargetUnitRepository.ts, workers/main/src/services/TargetUnit/TargetUnitRepository.ts	Removed groupName parameter from method signatures and corresponding query logic; updated interface and class.
Test updates for parameter removal workers/main/src/activities/weeklyFinancialReports/getTargetUnits.test.ts, workers/main/src/services/TargetUnit/TargetUnitRepository.test.ts, workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.test.ts	Updated all tests to call affected methods without the groupName parameter; removed related imports and checks.

Sequence Diagram(s)

sequenceDiagram
    participant Workflow
    participant Activity
    participant Repository

    Workflow->>Activity: getTargetUnits()
    Activity->>Repository: getTargetUnits()
    Repository-->>Activity: TargetUnit[]
    Activity-->>Workflow: GetTargetUnitsResult
    Workflow->>Activity: fetchFinancialAppData(...)
    Activity-->>Workflow: FinancialData
    Workflow->>Activity: sendToSlack(...)
    Activity-->>Workflow: FileLink

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15–20 minutes

Possibly related PRs

• Refactor getTargetUnits to accept group name parameter #61: Reversed the addition of the groupName parameter to getTargetUnits and related methods; this PR directly undoes those changes.
• Add GroupNameEnum in config #59: Introduced the GroupNameEnum and GroupName type, both of which are removed in this PR.
• Enhance weekly financial reports workflow with group name validation #60: Added the groupName parameter and validation to the workflow, which this PR now removes.

Suggested reviewers

• killev

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 384f686 and 5cd9a3a.

📒 Files selected for processing (7)

• workers/main/src/activities/weeklyFinancialReports/getTargetUnits.test.ts (2 hunks)
• workers/main/src/activities/weeklyFinancialReports/getTargetUnits.ts (1 hunks)
• workers/main/src/services/TargetUnit/ITargetUnitRepository.ts (1 hunks)
• workers/main/src/services/TargetUnit/TargetUnitRepository.test.ts (2 hunks)
• workers/main/src/services/TargetUnit/TargetUnitRepository.ts (2 hunks)
• workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.test.ts (2 hunks)
• workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: anatolyshipitz
PR: speedandfunction/automatization#34
File: workers/main/src/workflows/financial/FinancialReportFormatter.ts:3-7
Timestamp: 2025-05-30T17:57:21.010Z
Learning: User anatolyshipitz prefers to keep code implementations simple during early development stages rather than adding comprehensive error handling and validation. They consider extensive type annotations and error handling "redundant" when focusing on core functionality and testing.

workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.ts (3)

Learnt from: CR
PR: speedandfunction/automatization#0
File: .cursor/rules/temporal-project-structure.mdc:0-0
Timestamp: 2025-06-24T12:29:48.641Z
Learning: Workflow and activity logic in Temporal projects should be kept modular and well-tested, and all naming (workflows, activities, task queues) should be clear and descriptive to enhance code quality and maintainability.

Learnt from: CR
PR: speedandfunction/automatization#0
File: .cursor/rules/temporal-project-structure.mdc:0-0
Timestamp: 2025-06-24T12:29:48.641Z
Learning: In Temporal-based TypeScript projects, each worker should be structured as an independent package under 'workers//', with clear separation of workflows, activities, entry point, and documentation to promote modularity and maintainability.

Learnt from: CR
PR: speedandfunction/automatization#0
File: .cursor/rules/temporal-project-structure.mdc:0-0
Timestamp: 2025-06-24T12:29:48.641Z
Learning: When introducing new Temporal workers or workflows, it is essential to avoid duplicating logic already present in shared modules and to update documentation with every significant change to workflows or activities.

workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.test.ts (3)

Learnt from: CR
PR: speedandfunction/automatization#0
File: .cursor/rules/temporal-project-structure.mdc:0-0
Timestamp: 2025-06-24T12:29:48.641Z
Learning: Workflow and activity logic in Temporal projects should be kept modular and well-tested, and all naming (workflows, activities, task queues) should be clear and descriptive to enhance code quality and maintainability.

Learnt from: CR
PR: speedandfunction/automatization#0
File: .cursor/rules/temporal-project-structure.mdc:0-0
Timestamp: 2025-06-24T12:29:48.641Z
Learning: In Temporal-based TypeScript projects, each worker should be structured as an independent package under 'workers//', with clear separation of workflows, activities, entry point, and documentation to promote modularity and maintainability.

Learnt from: CR
PR: speedandfunction/automatization#0
File: .cursor/rules/temporal-project-structure.mdc:0-0
Timestamp: 2025-06-24T12:29:48.641Z
Learning: When introducing new Temporal workers or workflows, it is essential to avoid duplicating logic already present in shared modules and to update documentation with every significant change to workflows or activities.

🧬 Code Graph Analysis (5)

workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.ts (3)

workers/main/src/activities/weeklyFinancialReports/getTargetUnits.ts (1)

• getTargetUnits (11-30)

workers/main/src/services/TargetUnit/TargetUnitRepository.ts (1)

• getTargetUnits (36-50)

workers/main/src/configs/weeklyFinancialReport.ts (1)

• GroupNameEnum (1-4)

workers/main/src/services/TargetUnit/TargetUnitRepository.ts (2)

workers/main/src/common/types.ts (1)

• TargetUnit (3-14)

workers/main/src/services/TargetUnit/queries.ts (1)

• TARGET_UNITS_QUERY (67-99)

workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.test.ts (1)

workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.ts (1)

• weeklyFinancialReportsWorkflow (10-15)

workers/main/src/services/TargetUnit/ITargetUnitRepository.ts (1)

workers/main/src/common/types.ts (1)

• TargetUnit (3-14)

workers/main/src/services/TargetUnit/TargetUnitRepository.test.ts (1)

workers/main/src/common/errors/TargetUnitRepositoryError.ts (1)

• TargetUnitRepositoryError (3-7)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Docker Security Scanning (n8n, Dockerfile.n8n, n8n-test:latest)
• GitHub Check: Service Availability Check

🔇 Additional comments (15)

workers/main/src/activities/weeklyFinancialReports/getTargetUnits.ts (2)

11-11: LGTM! Function signature simplified correctly.

The removal of the groupName parameter streamlines the function interface as intended by the PR objectives.

---

17-17: Repository call updated correctly.

The parameterless call to repo.getTargetUnits() is consistent with the updated repository interface.

workers/main/src/services/TargetUnit/ITargetUnitRepository.ts (1)

4-4: Interface change verified – no remaining references to the old signature

I ran a full-text search across the repository and confirmed there are no calls to getTargetUnits(groupName: …) or imports of a GroupName parameter. All existing call sites (in the repository implementation, workflows, activities, and tests) now use the new parameterless signature.

This change is approved. Please continue to monitor performance when fetching large datasets.

workers/main/src/services/TargetUnit/TargetUnitRepository.ts (2)

36-36: Method signature updated correctly.

The parameterless signature matches the updated interface definition and aligns with the PR objectives.

---

38-38: Query execution updated correctly.

The parameterless query execution is consistent with removing the group filtering. The query will now return target units for all groups, which aligns with the simplified API design.

workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.ts (2)

11-11: Activity call updated correctly.

The parameterless call to getTargetUnits() is consistent with the updated activity signature and maintains the workflow's data flow.

---

10-10: No external invocations of weeklyFinancialReportsWorkflow detected
Searches for direct references and Temporal start patterns only returned the workflow itself and its tests. There are no client usages to update, so the parameterless signature is safe.

workers/main/src/services/TargetUnit/TargetUnitRepository.test.ts (1)

40-40: Test method calls updated correctly.

All test calls to getTargetUnits() have been consistently updated to the parameterless signature while maintaining comprehensive test coverage for success and error scenarios.

Also applies to: 58-58, 65-65

workers/main/src/activities/weeklyFinancialReports/getTargetUnits.test.ts (4)

116-123: LGTM: Function call correctly updated to remove groupName parameter.

The test case has been properly updated to call getTargetUnits() without any parameters, which aligns with the PR objective of removing the groupName parameter.

---

128-132: LGTM: Error handling test properly updated.

The error test correctly calls getTargetUnits() without parameters and maintains proper error assertion behavior.

---

137-141: LGTM: File writing error test properly updated.

The test case for file writing errors has been correctly updated to call getTargetUnits() without parameters while preserving the error handling validation.

---

146-148: LGTM: Redmine pool cleanup test updated correctly.

The test that verifies Redmine pool cleanup has been properly updated to call getTargetUnits() without parameters.

workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.test.ts (3)

47-50: LGTM: Error propagation test correctly updated.

The test properly calls weeklyFinancialReportsWorkflow() without parameters, which is consistent with the function signature after removing the groupName parameter.

---

55-58: LGTM: fetchFinancialAppData error test properly updated.

The error propagation test for fetchFinancialAppData has been correctly updated to call the workflow without parameters.

---

66-75: LGTM: Success test case properly updated.

The success test case correctly:

• Calls weeklyFinancialReportsWorkflow() without parameters
• Expects getTargetUnitsMock to be called with no arguments
• Maintains proper mock expectations for the activity chain

This aligns perfectly with the workflow signature shown in the relevant code snippet.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch issue/remove_group_name_filter

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🔍 Vulnerabilities of temporal-test:latest

📦 Image Reference temporal-test:latest

digest	sha256:da30eca7154c7c4cb2616e31f7411021ea9146d5b15c68adf2a57df4c52b164c
vulnerabilities
platform	linux/amd64
size	218 MB
packages	358

📦 Base Image alpine:3

also known as	3.21 3.21.3 latest
digest	sha256:1c4eef651f65e2f7daee7ee785882ac164b02b78fb74503052a26dc061c90474
vulnerabilities

stdlib 1.23.6 (golang) pkg:golang/[email protected] Affected range <1.23.8 Fixed version 1.23.8 EPSS Score 0.023% EPSS Percentile 4th percentile Description The net/http package improperly accepts a bare LF as a line terminator in chunked data chunk-size lines. This can permit request smuggling if a net/http server is used in conjunction with a server that incorrectly accepts a bare LF as part of a chunk-ext.

stdlib 1.23.2 (golang) pkg:golang/[email protected] Affected range <1.23.8 Fixed version 1.23.8 EPSS Score 0.023% EPSS Percentile 4th percentile Description The net/http package improperly accepts a bare LF as a line terminator in chunked data chunk-size lines. This can permit request smuggling if a net/http server is used in conjunction with a server that incorrectly accepts a bare LF as part of a chunk-ext.

golang.org/x/crypto 0.32.0 (golang) pkg:golang/golang.org/x/[email protected] Affected range <0.35.0 Fixed version 0.35.0 EPSS Score 0.127% EPSS Percentile 33rd percentile Description SSH servers which implement file transfer protocols are vulnerable to a denial of service attack from clients which complete the key exchange slowly, or not at all, causing pending content to be read into memory, but never transmitted.

golang.org/x/oauth2 0.7.0 (golang) pkg:golang/golang.org/x/[email protected] Improper Validation of Syntactic Correctness of Input Affected range <0.27.0 Fixed version 0.27.0 CVSS Score 7.5 CVSS Vector CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H EPSS Score 0.065% EPSS Percentile 21st percentile Description An attacker can pass a malicious malformed token which causes unexpected memory to be consumed during parsing.

github.com/golang-jwt/jwt/v4 4.5.1 (golang) pkg:golang/github.com/golang-jwt/[email protected]#v4 Asymmetric Resource Consumption (Amplification) Affected range <4.5.2 Fixed version 4.5.2 CVSS Score 8.7 CVSS Vector CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:H/SC:N/SI:N/SA:N EPSS Score 0.033% EPSS Percentile 8th percentile Description Summary Function parse.ParseUnverified currently splits (via a call to strings.Split) its argument (which is untrusted data) on periods. As a result, in the face of a malicious request whose Authorization header consists of Bearer followed by many period characters, a call to that function incurs allocations to the tune of O(n) bytes (where n stands for the length of the function's argument), with a constant factor of about 16. Relevant weakness: CWE-405: Asymmetric Resource Consumption (Amplification) Details See parse.ParseUnverified Impact Excessive memory allocation

c-ares 1.34.3-r0 (apk) pkg:apk/alpine/[email protected]?os_name=alpine&os_version=3.21 Affected range <1.34.5-r0 Fixed version 1.34.5-r0 EPSS Score 0.154% EPSS Percentile 37th percentile Description

go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc 0.36.4 (golang) pkg:golang/go.opentelemetry.io/contrib/[email protected]#google.golang.org/grpc/otelgrpc Allocation of Resources Without Limits or Throttling Affected range <0.46.0 Fixed version 0.46.0 CVSS Score 7.5 CVSS Vector CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H EPSS Score 2.744% EPSS Percentile 85th percentile Description Summary The grpc Unary Server Interceptor opentelemetry-go-contrib/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go // UnaryServerInterceptor returns a grpc.UnaryServerInterceptor suitable // for use in a grpc.NewServer call. func UnaryServerInterceptor(opts ...Option) grpc.UnaryServerInterceptor { out of the box adds labels net.peer.sock.addr net.peer.sock.port that have unbound cardinality. It leads to the server's potential memory exhaustion when many malicious requests are sent. Details An attacker can easily flood the peer address and port for requests. PoC Apply the attached patch to the example and run the client multiple times. Observe how each request will create a unique histogram and how the memory consumption increases during it. Impact In order to be affected, the program has to configure a metrics pipeline, use UnaryServerInterceptor, and does not filter any client IP address and ports via middleware or proxies, etc. Others It is similar to already reported vulnerabilities. GHSA-rcjv-mgp8-qvmr (open-telemetry/opentelemetry-go-contrib) GHSA-5r5m-65gx-7vrh (open-telemetry/opentelemetry-go-contrib) GHSA-cg3q-j54f-5p7p (prometheus/client_golang) Workaround for affected versions As a workaround to stop being affected, a view removing the attributes can be used. The other possibility is to disable grpc metrics instrumentation by passing otelgrpc.WithMeterProvider option with noop.NewMeterProvider. Solution provided by upgrading In PR #4322, to be released with v0.46.0, the attributes were removed. References #4322

golang.org/x/oauth2 0.26.0 (golang) pkg:golang/golang.org/x/[email protected] Improper Validation of Syntactic Correctness of Input Affected range <0.27.0 Fixed version 0.27.0 CVSS Score 7.5 CVSS Vector CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H EPSS Score 0.065% EPSS Percentile 21st percentile Description An attacker can pass a malicious malformed token which causes unexpected memory to be consumed during parsing.

github.com/golang-jwt/jwt 3.2.2+incompatible (golang) pkg:golang/github.com/golang-jwt/[email protected]%2Bincompatible Asymmetric Resource Consumption (Amplification) Affected range >=3.2.0 <=3.2.2 Fixed version Not Fixed CVSS Score 8.7 CVSS Vector CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:H/SC:N/SI:N/SA:N EPSS Score 0.033% EPSS Percentile 8th percentile Description Summary Function parse.ParseUnverified currently splits (via a call to strings.Split) its argument (which is untrusted data) on periods. As a result, in the face of a malicious request whose Authorization header consists of Bearer followed by many period characters, a call to that function incurs allocations to the tune of O(n) bytes (where n stands for the length of the function's argument), with a constant factor of about 16. Relevant weakness: CWE-405: Asymmetric Resource Consumption (Amplification) Details See parse.ParseUnverified Impact Excessive memory allocation

[killev]

Looks good!