Skip to content

Fix binary view cast #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix binary view cast #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion datafusion/sql/src/unparser/expr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,9 @@ impl Unparser<'_> {
let inner_expr = self.expr_to_sql_inner(expr)?;
match inner_expr {
ast::Expr::Value(_) => match data_type {
DataType::Dictionary(_, _) | DataType::Binary => Ok(inner_expr),
DataType::Dictionary(_, _) | DataType::Binary | DataType::BinaryView => {
Ok(inner_expr)
}
_ => Ok(ast::Expr::Cast {
kind: ast::CastKind::Cast,
expr: Box::new(inner_expr),
Expand Down Expand Up @@ -2204,6 +2206,13 @@ mod tests {
data_type: DataType::Binary,
}),
"'blah'",
Expr::Cast(Cast {
expr: Box::new(Expr::Literal(ScalarValue::Utf8(Some(
"blah".to_string(),
)))),
data_type: DataType::BinaryView,
}),
"'blah'",
)];
for (value, expected) in tests {
let dialect = CustomDialectBuilder::new().build();
Expand Down