Introduce OAuth2TokenGenerator #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrandja
added
status: duplicate
jgrandja
force-pushed
the
gh-414-token-generator
branch
from
8cb60f0 to
96c1dd2
Compare
sjohnr
reviewed
Feb 17, 2022
Contributor
sjohnr
left a comment
sjohnr
left a comment
There was a problem hiding this comment.
This looks pretty great so far! I have a few questions below for discussion, that could change something or other (but hopefully won't change much if anything).
...ity/oauth2/server/authorization/authentication/OAuth2RefreshTokenAuthenticationProvider.java
Show resolved
Hide resolved
...main/java/org/springframework/security/oauth2/server/authorization/OAuth2TokenGenerator.java
Show resolved
Hide resolved
sjohnr
approved these changes
Feb 18, 2022
jgrandja
force-pushed
the
gh-414-token-generator
branch
from
96c1dd2 to
f201022
Compare
sjohnr
reviewed
Feb 22, 2022
| * @return the {@link OAuth2AuthorizationServerConfigurer} for further configuration | ||
| * @since 0.2.3 | ||
| */ | ||
| public OAuth2AuthorizationServerConfigurer<B> tokenGenerator(OAuth2TokenGenerator<? extends OAuth2Token> tokenGenerator) { |
doba16
pushed a commit
to doba16/spring-authorization-server
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
OAuth2TokenGenerator, enabling an implementation to generate anOAuth2Token.The initial implementation is
JwtGenerator, which consolidates theJwtencoding logic that existed in the variousAuthenticationProvider's andJwtUtils.The
OAuth2TokenGeneratorwill enable support for Opaque Access Tokens gh-500, which is the next feature up.Furthermore, the
OAuth2TokenGeneratoris flexible enough to allow for any type of custom format for access tokens and/or refresh tokens.Closes gh-414