Document event publication from repository delete methods in AbstractAggregateRoot
#2903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added additional comment regarding registerEvent and andEvent in AbstractAggregateRoot.
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
type: documentation
mp911de
pushed a commit
that referenced
this pull request
Aug 16, 2023
…tAggregateRoot`. Added additional comment regarding registerEvent and andEvent in AbstractAggregateRoot. Closes: #2903
mp911de
pushed a commit
that referenced
this pull request
Aug 16, 2023
…tAggregateRoot`. Added additional comment regarding registerEvent and andEvent in AbstractAggregateRoot. Closes: #2903
mp911de
changed the title
AbstractAggregateRoot
|
Thank you for your contribution. That's merged and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registerEvent method works for either Spring Data repository's save or delete methods, but the comments only describe save.
I think it should be explained that it also works for the delete method, like in the EventPublishingMethodInterceptor class.