-
Couldn't load subscription status.
- Fork 1.2k
Support sentinel username in SentinelConfiguration
#2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@vikasgarghb Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@vikasgarghb Thank you for signing the Contributor License Agreement! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request. I added comments regarding minor issues. Also, the formatting seems odd, care to have a look? You can find the formatter settings at https://github.com/spring-projects/spring-data-build/tree/main/etc/ide
src/main/java/org/springframework/data/redis/connection/lettuce/LettuceConverters.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/data/redis/connection/lettuce/LettuceConvertersUnitTests.java
Outdated
Show resolved
Hide resolved
…on and more tests.
|
@mp911de Can this be approved, merged and made part of the next release? |
|
Thanks a lot. I'm picking up this PR from here. |
SentinelConfiguration
|
Thank you for your contribution. That's merged and polished now. |
This pull request allows you to provide username for sentinel which in turn allows support for ACL based authentication provided with redis 6.
This covers the issue mentioned here: #2218