Skip to content

Conversation

@vikasgarghb
Copy link
Contributor

  • [ X ] You have read the Spring Data contribution guidelines.
  • [ X ] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [ X ] You submit test cases (unit or integration tests) that back your changes.
  • [ X ] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

This pull request allows you to provide username for sentinel which in turn allows support for ACL based authentication provided with redis 6.

This covers the issue mentioned here: #2218

@pivotal-cla
Copy link

@vikasgarghb Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2022
@pivotal-cla
Copy link

@vikasgarghb Thank you for signing the Contributor License Agreement!

@mp911de mp911de self-assigned this Jan 5, 2022
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 5, 2022
@mp911de mp911de added this to the 2.7 M1 (2021.2.0) milestone Jan 5, 2022
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request. I added comments regarding minor issues. Also, the formatting seems odd, care to have a look? You can find the formatter settings at https://github.com/spring-projects/spring-data-build/tree/main/etc/ide

@vikasgarghb vikasgarghb requested a review from mp911de January 5, 2022 15:21
@vikasgarghb
Copy link
Contributor Author

@mp911de Can this be approved, merged and made part of the next release?

@mp911de
Copy link
Member

mp911de commented Jan 7, 2022

Thanks a lot. I'm picking up this PR from here.

@mp911de mp911de changed the title Add support for providing sentinel username. Support sentinel username in SentinelConfiguration Jan 7, 2022
mp911de pushed a commit that referenced this pull request Jan 7, 2022
mp911de added a commit that referenced this pull request Jan 7, 2022
Reformat code. Consider sentinel username in JedisConnectionFactory. Update years in license headers.

See #2218
Original pull request: #2224.
@mp911de
Copy link
Member

mp911de commented Jan 7, 2022

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Jan 7, 2022
@vikasgarghb vikasgarghb deleted the sentinel-username branch January 7, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants