Skip to content

Conversation

@ben-enfuse-io
Copy link
Contributor

…b.com//issues/28305

In this commit we added MariaDB as an independent database type as per #28305

Thanks for taking time to look at it!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 18, 2022
@snicoll
Copy link
Member

snicoll commented Jul 29, 2022

This looks like an oversight of #25811 - what do you think @jhoeller

@snicoll snicoll changed the title Treat MariaDB as an independent database type. Resolves https://githu… Treat MariaDB as an independent database type Jul 29, 2022
@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 22, 2022
@jhoeller jhoeller added this to the 6.0.0-M6 milestone Aug 22, 2022
@snicoll snicoll self-assigned this Aug 23, 2022
snicoll pushed a commit that referenced this pull request Aug 23, 2022
@snicoll snicoll closed this in 5655103 Aug 23, 2022
@snicoll
Copy link
Member

snicoll commented Aug 23, 2022

@ben-enfuse-io thank you for making your first contribution to Spring Framework.

@fmbenhassine
Copy link
Contributor

Shouldn't Spring Framework provide a dedicated DataFieldMaxValueIncrementer for MariaDB as well? I think treating MariaDB as an independent database should not be limited to the change in this PR.

For example, we have the same request in Spring Batch (see spring-projects/spring-batch#3891), where we use a DataFieldMaxValueIncrementer to increment the IDs of the Batch domain model entities, and it feels odd to use the MySQL incrementer with MariaDB. Do you agree?

@snicoll
Copy link
Member

snicoll commented Oct 12, 2022

@fmbenhassine please create a separate issue where we can have that discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants