Improve test coverage of RdbmsOperation #28472
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiayiLi1999
commented
May 18, 2022
JiayiLi1999
commented
- getSql()
- tooManyMapParameters()
added 2 commits
May 17, 2022 19:49
1. getSql() 2. tooManyMapParameters()
spring-projects-issues
added
the
status: waiting-for-triage
mahadevshindhe
approved these changes
May 18, 2022
snicoll
changed the title
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Jul 29, 2022
snicoll
added a commit
that referenced
this pull request
Jul 29, 2022
Member
|
Thank you for making your first contribution to Spring Framework, @JiayiLi1999. I didn't include the SQL test as it's testing the getter and we prefer to test the outcome of setting the property. I've also noticed that some tests were not testing what they were supposed to (including the test you added) as the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.