GH-2148: Fix MeterRegistry Detection #2151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#2148 - use Boot's `AutoConfiguredCompositeMeterRegistry`, if only one (tested with a Boot application) - use `@Primary` registry bean **cherry-pick to 2.8.x**
artembilan
requested changes
Mar 7, 2022
| .getClass() | ||
| .getName() | ||
| .equals("org.springframework.boot.actuate.autoconfigure.metrics." | ||
| + "AutoConfiguredCompositeMeterRegistry")) |
There was a problem hiding this comment.
Why do we need this if it is @Primary in the auto-configuration:
@Bean
@Primary
AutoConfiguredCompositeMeterRegistry compositeMeterRegistry(Clock clock, List<MeterRegistry> registries) {
return new AutoConfiguredCompositeMeterRegistry(clock, registries);
}
?
I mean it looks like the next logic covers this Spring Boot "pollution" as well.
Do I miss anything ?
Thanks
There was a problem hiding this comment.
Oh; thanks; I didn't look at that; I just saw 3 beans in my test app; will test and push.
|
... and cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2148
AutoConfiguredCompositeMeterRegistry, if only one(tested with a Boot application)
@Primaryregistry beancherry-pick to 2.8.x