GH-2329: Fix interceptBeforeTx for Non-Kafka TM #2330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#2329 The flag should apply, regardless of PTM type.
artembilan
requested changes
Jul 6, 2022
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
LGTM, but I wonder if it is legit to back-port it down to 2.8.x.
Isn't it possible that someone relies on the current behavior?
I'm OK cherry-picking this to 2.9.x, but I have some backward compatibility concern for 2.8.x.
Thanks
Contributor
Author
|
OK; I am fine with that given that there is a work around (use an advice instead). I will push doc changes (and what's new) after merge. |
Member
|
... and cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2329
The flag should apply, regardless of PTM type.
cherry-pick to 2.9.x,