Remove provided deps from the target POM
#2342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to spring-projects/spring-framework#23486 We have this `providedApi 'org.junit.platform:junit-platform-launcher'` where its `version` is resolved from `mavenBom "org.junit:junit-bom:$junitJupiterVersion"`. When we generate a Maven POM, this kind of dependency is present as an `optional` by default. We previously have overridden this to the `provided`, but it comes without a `version`. According to Spring Framework decision this kind of transitive dependencies are misleading. * Remove any `provided` deps in Gradle from the target POM altogether
Member
Author
|
/CC @benas |
fmbenhassine
added a commit
to spring-projects/spring-batch
that referenced
this pull request
Jul 13, 2022
These tests are failing due to an invalid pom in spring-kafka-test Related issue: spring-projects/spring-kafka#2342
fmbenhassine
added a commit
to spring-projects/spring-batch
that referenced
this pull request
Jul 13, 2022
These tests were temporarily disabled, see 85a9cad. Now that spring-projects/spring-kafka#2342 is fixed, these tests are re-enabled again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to spring-projects/spring-framework#23486
We have this
providedApi 'org.junit.platform:junit-platform-launcher'where its
versionis resolved frommavenBom "org.junit:junit-bom:$junitJupiterVersion".When we generate a Maven POM, this kind of dependency is present as an
optionalby default.We previously have overridden this to the
provided, but it comes without aversion.According to Spring Framework decision this kind of transitive dependencies are misleading.
provideddeps in Gradle from the target POM altogether