Skip to content

Conversation

cfredri4
Copy link
Contributor

This updates the listener observation operation tag according to latest standard.

E.g. Open Telemetry states:

The consumer receives, processes, and settles a message. "Receiving" is the process of obtaining a message from the intermediary, "processing" is the process of acting on the information a message contains, "settling" is the process of notifying an intermediary that a message was processed successfully.

E.g. Micrometer JMS follows this.

private static final KeyValue OPERATION_PROCESS = KeyValue.of(LowCardinalityKeyNames.OPERATION, "process");

This updates the listener observation operation tag according to latest standard.

Signed-off-by: Christian Fredriksson <[email protected]>
@cfredri4 cfredri4 force-pushed the update-listener-observation-operation-tag branch from 99ac717 to 2cdeb08 Compare September 29, 2025 10:49
@jonatan-ivanov
Copy link
Member

I would like to call out a few things:

  • The OTel doc you quoted from says this: "Status: Experimental". It's unstable, it's not really a standard that you want to use in prod since it's likely it will have breaking changes in the future.
  • Doing this is a breaking change, it can break dashboards/alerts/etc.

I think it is fine to change this (in the next major version) if we think it's worth to introduce this (breaking) change to make it more similar to the instrumentation of JMS and/or have a better name (if we think it's better).

@artembilan
Copy link
Member

Thanks, @jonatan-ivanov , for confirmation.

I think we can bite a bullet and updated the Kafka listener observation into a process in our current 4.0.0.
We may introduce a receive operation for the KafkaConsumer.poll() in the future.

@artembilan artembilan added this to the 4.0.0-RC1 milestone Oct 1, 2025
@artembilan artembilan added type: enhancement ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. and removed ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. labels Oct 1, 2025
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sobychacko ,

let me know if you'd like to take a look before I merge this.

Thanks

@sobychacko
Copy link
Contributor

Go ahead @artembilan with the merge.

@artembilan artembilan merged commit 17fe0ff into spring-projects:main Oct 1, 2025
3 checks passed
@cfredri4 cfredri4 deleted the update-listener-observation-operation-tag branch October 2, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants