Skip to content

Fix the bug that the custom GrantedAuthority comparison fails #10588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2021
Merged

Fix the bug that the custom GrantedAuthority comparison fails #10588

merged 1 commit into from
Dec 8, 2021

Conversation

terminux
Copy link
Contributor

@terminux terminux commented Dec 6, 2021

Closes gh-10566

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 6, 2021
@terminux terminux mentioned this pull request Dec 6, 2021
Closed
marcusdacoregio
marcusdacoregio suggested changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@marcusdacoregio marcusdacoregio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @terminux. Thanks for the PR.

I've left some minimum feedback inline.

Additionally, can you change the base branch to 5.7.x and rebase your gh-10566 branch with 5.7.x instead of main? This is because the main branch is being used to the 6.0 version, and 5.7 is the next release.

@marcusdacoregio marcusdacoregio added in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 7, 2021
@marcusdacoregio marcusdacoregio added this to the 5.7.0-M1 milestone Dec 7, 2021
@terminux
Copy link
Contributor Author

terminux commented Dec 8, 2021

Thank you for using your precious time to review my code @marcusdacoregio . I've updated the PR.

@terminux terminux changed the base branch from main to 5.7.x December 8, 2021 02:41
marcusdacoregio
marcusdacoregio approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@marcusdacoregio marcusdacoregio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@marcusdacoregio marcusdacoregio merged commit 22379e7 into spring-projects:5.7.x Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@marcusdacoregio marcusdacoregio marcusdacoregio approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Milestone
5.7.0-M1
Development

Successfully merging this pull request may close these issues.

AuthorityAuthorizationManager incorrectly compares GrantedAuthority
3 participants
@terminux @marcusdacoregio @spring-projects-issues