'KeyStoreUtils.loadDefaultKeyStore()' issue [SWS-370]

[gregturn]

Michel Zanini opened SWS-370 and commented

In the loadDefaultKeyStore method of org.springframework.ws.soap.security.support.KeyStoreUtils class I found this code:

....
String passwordProperty = System.getProperty("javax.net.ssl.keyStorePassword");
if (StringUtils.hasLength(passwordProperty)) {
password = passwordProperty;
}
type = System.getProperty("javax.net.ssl.trustStore");
}
....

In the line, System.getProperty("javax.net.ssl.trustStore"), the String parameter should be "javax.net.ssl.keyStoreType", right?

---

Affects: 1.5.2

Referenced from: commits c39df00

[gregturn]

Michel Zanini commented

It is possible to move the package 'org.springframework.ws.soap.security.support' to another component? Maybe the spring-ws-core or spring-ws-support.

I need this package to easy configure SSL and i don't want spring-ws-security component and this dependencies. The package is not related ONLY with ws-security, but with security in general. Even better, for me, if this classes would be in the springframework.

[gregturn]

Arjen Poutsma commented

As for moving the class to Spring Core, that would be hard, since Spring-WS depends on this package name, and has to be backwards compatible with earlier versions.

[gregturn]

Arjen Poutsma commented

Resolved, thanks for pointing this out!

[gregturn]

Arjen Poutsma commented

Closing issues in 1.5.3