Skip to content

Conversation

@mdeinum
Copy link
Contributor

@mdeinum mdeinum commented Oct 20, 2022

Align with other projects from the portfolio and provide a spring-ws-bom to make it easier to manage dependencies.

Closes: #1205

Align with other projects from the portfolio and provide a spring-ws-bom to make it easier to manage dependencies.

Closes: spring-projects#1205
@mdeinum mdeinum changed the title Spring WS B Spring WS - Bill of Materials (bom) Oct 31, 2022
@gregturn
Copy link
Contributor

@mdeinum I am tracking this feature request through #1290.

I had initially picked this up, but due to it connecting to a parent POM that in turn pulled in OTHER Spring BOMs, it introduced a cascade of dependencies not acceptible to the Boot team.

Hence, we need something a little more subtle and having this this late in the 4.0 life cycle won't work.

@gregturn gregturn closed this Nov 16, 2022
@mdeinum
Copy link
Contributor Author

mdeinum commented Nov 17, 2022

I commented on that one as well. I didn't check the parent pom when I initially created the bom. However as the dependencyManagement section is in the parent this is problematic. I checked some other Spring projects as well and Spring WS is the odd one out in that regard.

Moving the dependencies to a separate project abd use that as a dependency bom and then import that into the other projects would solve it I guess.

Or take this as an opportunity to move to Gradle and use the platform feature of Gradle for this. But maybe that is something for the 4.1 timeframe?

gregturn added a commit that referenced this pull request Jan 5, 2023
The Spring WS BOM itself uses the flatten-maven-plugin to produce a POM file simplified for community consumption. The same plugin is ready to go for the other modules. But given the risk of breaking existing users, it will not be applied until Spring WS 4.1 is released (#1307).

Resolves #1290.
Related: #1205, #1285.
@gregturn
Copy link
Contributor

gregturn commented Jan 5, 2023

@mdeinum You may not be aware, but I actually migrated this project away from Gradle and back to Maven several years ago.

As for having the BOM in a separate project, I was able to pick a solution that didn't require going that far, considering all the BOM's modules are right here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants