Skip to content

Better conversion from ByteArrayOutputStream to String. #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Better conversion from ByteArrayOutputStream to String. #1324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s-support/src/main/java/org/springframework/ws/transport/jms/TextMessageOutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public void flush() throws IOException {
super.flush();
try {
ByteArrayOutputStream baos = (ByteArrayOutputStream) out;
String text = new String(baos.toByteArray(), encoding);
String text = baos.toString(encoding);
message.setText(text);
} catch (JMSException ex) {
throw new JmsTransportException(ex);
Expand Down
2 changes: 1 addition & 1 deletion ...g-ws-support/src/main/java/org/springframework/ws/transport/xmpp/MessageOutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class MessageOutputStream extends FilterOutputStream {
public void flush() throws IOException {
super.flush();
ByteArrayOutputStream bos = (ByteArrayOutputStream) out;
String text = new String(bos.toByteArray(), encoding);
String text = bos.toString(encoding);
message.setBody(text);
}
}
2 changes: 1 addition & 1 deletion ...t/src/test/java/org/springframework/ws/transport/jms/JmsMessageSenderIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public void testSendAndReceiveQueueTextMessage() throws Exception {

ByteArrayOutputStream bos = new ByteArrayOutputStream();
messageFactory.createMessage().writeTo(bos);
final String text = new String(bos.toByteArray(), StandardCharsets.UTF_8);
final String text = bos.toString(StandardCharsets.UTF_8);

jmsTemplate.send(request.getJMSReplyTo(), session -> {

Expand Down