Adds testing targets and libraries to SPM #124
Conversation
|
|
| targets: ["WorkflowReactiveSwift"] | ||
| ), | ||
| .library( | ||
| name: "WorkflowCombine", |
There was a problem hiding this comment.
Does this also need to be added to CI, or will it run already?
There was a problem hiding this comment.
Good question. I'm not familiar with the Github CI infra perhaps @mjohnson12 you have a better idea?
There was a problem hiding this comment.
I believe the CI build uses the podspec for running the tests which doesn't include anything that requires iOS 13+ since cocoapods would require workflow to require iOS 13+ so those are commented out in Development.podspec.
There is one CI test that runs with package manager but I don't know which tests it runs.
There was a problem hiding this comment.
Looking at the output of the swift package manager CI step and it does not run the WorkflowCombine tests.
There was a problem hiding this comment.
I've pushed up an update that adds WorkflowCombine to the tests that run for the SPM CI build step.
mjohnson12
left a comment
mjohnson12
left a comment
There was a problem hiding this comment.
As mentioned in Slack the Workflow package doesn't build for testing for me.
pbelonsquare
force-pushed
the
export_testing
branch
from
e0dbf5f to
1ae3ec4
Compare
| ), | ||
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/ReactiveCocoa/ReactiveSwift.git", from: "6.3.0"), |
There was a problem hiding this comment.
.package(url: "https://github.com/nicklockwood/SwiftFormat", .exact("0.44.14")),
Is there a reason we are pinning the SwiftFormat version?
Should generally use from and then depend on a Package.resolved file
There was a problem hiding this comment.
@dhavalshreyas Do you know why this dependency is pinned at an exact version?
Added test target for WorkflowReactiveSwift Fixed building WorkflowCombine tests via SPM
No description provided.