Added Concurrency Testing #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieQ
reviewed
Oct 3, 2022
| import XCTest | ||
| @testable import WorkflowCombineTesting | ||
|
|
||
| @available(iOS 13.0, macOS 10.15, *) |
Contributor
There was a problem hiding this comment.
why were all these availability annotations needed?
Collaborator
Author
There was a problem hiding this comment.
I added the testing target for those to the package and because the package is iOS 12+ right now. You can't set minimum OS targets for products only packages unfortunately.
Kiesco08
reviewed
Oct 3, 2022
Comment on lines
+185
to
+191
| # s.test_spec 'WorkflowConcurrencyTestingTests' do |test_spec| | ||
| # test_spec.requires_app_host = true | ||
| # test_spec.source_files = 'WorkflowConcurrency/TestingTests/**/*.swift' | ||
| # test_spec.framework = 'XCTest' | ||
| # test_spec.dependency 'WorkflowTesting' | ||
| # test_spec.dependency 'WorkflowConcurrencyTesting' | ||
| # end |
There was a problem hiding this comment.
Do we need to add this if it's disabled?
Collaborator
Author
There was a problem hiding this comment.
It's added so when we switch the minimum OS to higher than 12 we just uncomment so we don't forget to add that target.
jamieQ
reviewed
Oct 3, 2022
Kiesco08
approved these changes
Oct 3, 2022
jamieQ
approved these changes
Oct 3, 2022
Contributor
jamieQ
left a comment
jamieQ
left a comment
There was a problem hiding this comment.
lgtm. just had one thought about unifying naming conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist