-
Notifications
You must be signed in to change notification settings - Fork 47
Abstract ViewEnvironment to shared framework #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
259138b
ebd8bc0
f5e9e1b
bd9dcba
e410bc6
d8255ea
f69e7a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| require_relative('version') | ||
|
|
||
| Pod::Spec.new do |s| | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any tests to move too?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't see any but I thought about adding a simple
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not necessary here, but there is logical surface area to cover in the |
||
| s.name = 'ViewEnvironment' | ||
| s.version = WORKFLOW_VERSION | ||
| s.summary = 'A collection of environment values propagated through a view hierarchy.' | ||
| s.homepage = 'https://www.github.com/square/workflow-swift' | ||
| s.license = 'Apache License, Version 2.0' | ||
| s.author = 'Square' | ||
| s.source = { :git => 'https://github.com/square/workflow-swift.git', :tag => "v#{s.version}" } | ||
|
|
||
| # 1.7 is needed for `swift_versions` support | ||
| s.cocoapods_version = '>= 1.7.0' | ||
|
|
||
| s.swift_versions = ['5.0'] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: move these things into
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems reasonable to me—but I'm going to leave it as for this PR to avoid conflating that change here. |
||
| s.ios.deployment_target = '11.0' | ||
| s.osx.deployment_target = '10.13' | ||
|
|
||
| s.source_files = 'ViewEnvironment/Sources/**/*.swift' | ||
|
|
||
| s.pod_target_xcconfig = { 'APPLICATION_EXTENSION_API_ONLY' => 'YES' } | ||
| end | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| @_exported import ViewEnvironment | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a compatibility gesture, right? Assuming that My hunch is that it's fine, and that there's probably a lot of
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Yup!
I believe so |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but I bet we can turn these on globally now cc @jamieQ
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe we can if this is to work around a bug in
pod genunless we're bumping all podspecs to iOS 13.The project attempts to generate with an iOS 11 deployment target and fails to resolve all targets as a result (since these commented ones require iOS 14). I just reported the bug in #cocoapods here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured we could bump stuff in the whole repo to 14 as well. Anyway, not important for this PR!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect that you'd be able generate a project with
pod genwhich ends up just using the highest deployment target found in your development podspecs, but it doesn't appear to work this way (it's either an order thing or choosing the lowest version I think).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking into bumping the versions here. can do that after this is merged though & will update the values in the new podspec.