[feat]: add primary associated types to more protocols #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
approved these changes
Feb 3, 2023
jamieQ
commented
Feb 6, 2023
| public protocol Worker<Output>: AnyWorkflowConvertible where Rendering == Void { | ||
| /// The type of output events returned by this worker. | ||
| associatedtype Output | ||
| associatedtype WorkerPublisher: Publisher where |
Contributor
Author
There was a problem hiding this comment.
i assume we don't want this one to also be a primary associated type, but do correct me if there's some use case in which that would be valuable that i'm overlooking
mjohnson12
approved these changes
Feb 6, 2023
jamieQ
added a commit
that referenced
this pull request
Feb 6, 2023
* main: [fix]: use weak reference to internal sinks when vending to clients (#189) [feat]: add primary associated types to more protocols (#188) [chore]: pre major version bump cleanup (#187) [chore]: bump minimum deployment & swift versions (#186) Abstract ViewEnvironment to shared framework (#185) Bump activesupport from 6.1.4.4 to 6.1.7.1 (#183) [feat]: add primary associated types to `Workflow` protocol (#181) [chore]: update swiftformat ifdef indent rule to no-indent (#182)
jamieQ
added a commit
that referenced
this pull request
Feb 25, 2023
…ow-workflow-conformance * origin/main: Expose AnyScreen.wrappedScreen for inspection (#193) Improve introspection for SignalProducerWorkflow actions (#192) [release]: bump version to 2.2.0 & remove separate concurrency version (#191) [feat]: add runtime observation API (#168) [chore]: refactor some internal actions to use existential any (#190) [fix]: use weak reference to internal sinks when vending to clients (#189) [feat]: add primary associated types to more protocols (#188) [chore]: pre major version bump cleanup (#187) [chore]: bump minimum deployment & swift versions (#186) Abstract ViewEnvironment to shared framework (#185)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
since we've bumped to swift 5.7, let's add primary associated types in some more places
<Rendering, Output>PAT toAnyWorkflowConvertible<WorkflowType>PAT toWorkflowAction<Output>to the various definitions ofWorkerChecklist