Resolved Swift 5.9 compilation warning related to UnsafeRawPointer object conversion #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
n8chur
approved these changes
Aug 29, 2023
square-tomb
approved these changes
Aug 30, 2023
Contributor
square-tomb
left a comment
square-tomb
left a comment
There was a problem hiding this comment.
I take it that the keys can have any value type (and any initial value) to avoid this warning, and that UInt8 and 0 are chosen here just because the former is small?
Member
Author
Yeah exactly. The value is meaningless but UInt8 is used to save a bit of memory. |
square-tomb
added a commit
that referenced
this pull request
Nov 4, 2023
…ftui-testbed * 'main' of github.com:square/workflow-swift: Add WorkflowSwiftUIExperimental (#252) Add convenience method for library definitions to reduce boilerplate (#251) [release]: bump to version 3.4.0 (#250) RxSwift 6.6 (#212) Expose 'screen' on WorkflowHostingController (#246) [fix]: address some RenderTester limitations with optionals (#245) Resolved Swift 5.9 compilation warning related to UnsafeRawPointer object conversion (#243) Bump activesupport from 6.1.7.3 to 6.1.7.6 (#242)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 5.9 introduced a new warning related to object conversions to
UnsafeRawPointer.This updates the key type on associated object invocations to be a
UInt8which avoids the warning.Checklist