Skip to content

[gardening]: batch swiftlint calls for all modified files #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2024
Merged

[gardening]: batch swiftlint calls for all modified files #261

merged 1 commit into from
Jan 2, 2024

Conversation

jamieQ
Copy link
Contributor

@jamieQ jamieQ commented Jan 2, 2024

Issue

the current pre-commit hook builds & runs swiftformat on every lint-able file, which can take a relatively long time if many changes have been made

Description

  • updates commit hook script to make one call to swiftformat with all the files to lint
  • adds a swiftversion config specifying 5.7 as the language version the linter will use when running

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@jamieQ jamieQ marked this pull request as ready for review January 2, 2024 17:03
@jamieQ jamieQ requested a review from a team as a code owner January 2, 2024 17:03
@jamieQ jamieQ merged commit 54d7ece into main Jan 2, 2024
@jamieQ jamieQ deleted the jquadri/pre-commit-linter-speedup branch January 2, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jbmorgan jbmorgan jbmorgan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamieQ @jbmorgan