[RI-50004] Expose Workflow value to apply (breaking)
#262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
square-tomb
changed the title
apply (breaking)
square-tomb
force-pushed
the
tomb/workflow-in-apply-breaking
branch
from
6927506 to
7f970d8
Compare
Replace ``` func apply\(toState ([a-zA-Z0-9_]+): inout ([a-zA-Z0-9_\.<>, ]+|\(\))\) -> ([a-zA-Z0-9_\.<>, ]+)\? ``` with ``` func apply(toState $1: inout $2, workflow: WorkflowType) -> $3? ```
square-tomb
force-pushed
the
tomb/workflow-in-apply-breaking
branch
from
7f970d8 to
0207e16
Compare
square-tomb
force-pushed
the
tomb/workflow-in-apply-breaking
branch
from
0207e16 to
5fb03fa
Compare
square-tomb
force-pushed
the
tomb/workflow-in-apply-breaking
branch
from
949f919 to
1f239e2
Compare
square-tomb
commented
Mar 22, 2025
Comment on lines
+286
to
+289
|
|
||
| private let workflow = AuthenticationWorkflow( | ||
| authenticationService: AuthenticationService() | ||
| ) |
There was a problem hiding this comment.
TODO: make this an ivar with setup/teardown in case AuthenticationService is stateful
square-tomb
commented
Mar 22, 2025
| intermediateSession: "intermediateSession" | ||
| ) | ||
| workflow: workflow, | ||
| state: .authorizingTwoFactor(twoFactorCode: "123456", intermediateSession: "session") |
There was a problem hiding this comment.
TODO: preserve original parameter values
square-tomb
commented
Mar 22, 2025
| typealias WorkflowType = ___VARIABLE_productName___Workflow | ||
|
|
||
| func apply(toState state: inout ___VARIABLE_productName___Workflow.State) -> ___VARIABLE_productName___Workflow.Output? { | ||
| func apply(toState state: inout ___VARIABLE_productName___Workflow.State, workflow: WorkflowType) -> ___VARIABLE_productName___Workflow.Output? { |
square-tomb
commented
Mar 22, 2025
| typealias WorkflowType = ___VARIABLE_productName___Workflow | ||
|
|
||
| func apply(toState state: inout ___VARIABLE_productName___Workflow.State) -> ___VARIABLE_productName___Workflow.Output? { | ||
| func apply(toState state: inout ___VARIABLE_productName___Workflow.State, workflow: WorkflowType) -> ___VARIABLE_productName___Workflow.Output? { |
square-tomb
commented
Mar 22, 2025
| typealias WorkflowType = ___VARIABLE_productName___Workflow | ||
|
|
||
| func apply(toState state: inout ___VARIABLE_productName___Workflow.State) -> ___VARIABLE_productName___Workflow.Output? { | ||
| func apply(toState state: inout ___VARIABLE_productName___Workflow.State, workflow: WorkflowType) -> ___VARIABLE_productName___Workflow.Output? { |
square-tomb
commented
Mar 22, 2025
square-tomb
commented
Mar 22, 2025
square-tomb
commented
Mar 22, 2025
square-tomb
commented
Mar 22, 2025
square-tomb
commented
Mar 22, 2025
square-tomb
commented
Mar 22, 2025
square-tomb
changed the title
apply (breaking)apply (breaking)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation of #259 that includes breaking changes, which would require a major version bump and for all declarations of types conforming to
WorkflowActionto be updated.