[chore]: relax swiftui experimental dependency constraints & bump version #265
Conversation
| s.dependency 'Workflow', "~> #{WORKFLOW_MAJOR_VERSION}.0" | ||
| s.dependency 'WorkflowUI', "~> #{WORKFLOW_MAJOR_VERSION}.0" |
There was a problem hiding this comment.
Say a new major version of Workflow comes out at 4.0.0, seems like that's only when you'd want this dependency to change? So you'd wanna ignore things like 3.6.1, 3.7.0 as well as 4.1.0, 4.1.1, etc? Just wanna make sure I understand the intention here.
There was a problem hiding this comment.
yeah, this change means that version 0.2 of this pod requires version 3.x.y of its two dependencies, but any one will do.
| s.dependency 'Workflow', "~> #{WORKFLOW_MAJOR_VERSION}.0" | ||
| s.dependency 'WorkflowUI', "~> #{WORKFLOW_MAJOR_VERSION}.0" |
There was a problem hiding this comment.
A possible alternative is hardcoding the version bound like this, which could save you from having to touch this file at all when you are bumping the major version of the other modules. But then you'd still have to bump WorkflowSwiftUIExperimental in a separate change for Register's sake.
Also, I feel like there may have been some other reason I didn't do this 🤔
| s.dependency 'Workflow', "~> #{WORKFLOW_MAJOR_VERSION}.0" | |
| s.dependency 'WorkflowUI', "~> #{WORKFLOW_MAJOR_VERSION}.0" | |
| s.dependency 'Workflow', "~> 3.0" | |
| s.dependency 'WorkflowUI', "~> 3.0" |
3 participants
Description
the current experimental swift ui target is versioned independently from the other pods. this change relaxes the version requirements for its dependencies to allow any minor or patch changes to be made without this podspec having to be changed.