Double arrow tokenized as T_STRING when placed after non-arrow function "fn" keyword

[jrfnl]

Given the below code sample, PHP itself tokenizes the => as T_DOUBLE_ARROW, however, since PHPCS 3.5.4, PHPCS tokenizes it as T_STRING.

I haven't traced back yet which commit introduced this, nor figured out yet where to apply the fix.

class Foo {
    public $fn = 'key';

    public function bar() {
        return [
            $this->fn => 'value',
        ];
    }
}

https://3v4l.org/OXelC

Related to #2523

[gsherwood]

This issue is caused by this change: 0e4fe74

[gsherwood]

The previous change also included the changing of the function name token into a string, which wasn't required for arrow functions, and actually caused a problem given it assumed the next token as a name. Even though the function being called is not actually an arrow function, that decision doesn't happen until processAdditional(), so it looks like one on the first pass.

This is fixed now. Thanks for reporting it.

[jrfnl]

@gsherwood Thanks for fixing this!