Generic/InlineControlStructure: bug fix for try/catch/finally #3347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi-catch and `finally` statements were not taken into account when determining the end of the statement within an inline control structure. Fixed now. Includes unit tests. Fixes 3345
|
Hey @gsherwood , just to make sure but, I wasn't relevant to review this PR right ? Any place I can find your review process ? |
Member
Nope, I'll review it when I get time. Happy for you or others to test and give your opinion though. |
|
I tested it, it indeed fixes the bug |
gsherwood
added a commit
that referenced
this pull request
May 27, 2021
Member
|
Thanks for fixing this |
jrfnl
deleted the
feature/3345-generic-inlinecontrolstructures-bugfix-multicatch-finally
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-catch and
finallystatements were not taken into account when determining the end of the statement within an inline control structure.Fixed now.
Includes unit tests.
Fixes #3345