Generic/ScopeIndent: minor bug fix (undefined array index) #3365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking at issue 3362 in an attempt to debug it, binarykitten and me came across a `An error occurred during processing; checking has been aborted. The error message was: Undefined array key "" in /src/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php on line 646 (Internal.Exception)` error notice. While this will probably only occur in exceptional circumstances, it was caused by an operator precedence issue in the scope closer check condition. Adding the extra parentheses fixes the operator precedence snafu and prevents the above error notice. Note: this does not fix 3362, but still, is one less bug to worry about ;-)
Member
|
Thanks for spotting this. Would be great to have a code sample to expose the issue, but it is 100% an error regardless. |
Contributor
Author
|
Yeah, we tried to come up with an isolated code sample for this at the time, but that turned out to be pretty hard. Considering it is from quite a while back, I can barely remember how we managed to get that error in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at issue #3362 in an attempt to debug it, @BinaryKitten and me came across a
An error occurred during processing; checking has been aborted. The error message was: Undefined array key "" in /src/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php on line 646 (Internal.Exception)error notice.While this will probably only occur in exceptional circumstances, it was caused by an operator precedence issue in the scope closer check condition.
Adding the extra parentheses fixes the operator precedence snafu and prevents the above error notice.
Note: this does not fix #3362, but still, is one less bug to worry about ;-)