PHP 8.0 | PEAR/VariableComment: prevent false positives with attributes #3399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.0+ attributes can be placed between a docblock and the property declaration it applies to. The `Squiz.Commenting.VariableComment` sniff did not yet take this into account. This would result in a false positive `Missing member variable doc comment` error. Fixed now.
jrfnl
changed the title
Member
|
Thanks for this fix. I found a related one in the Squiz MemberVarSpacing sniff which I also fixed. |
Contributor
Author
|
@gsherwood Ah, yes there are probably still more. I looked through and fixed all sniffs in the various |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0+ attributes can be placed between a docblock and the property declaration it applies to.
The
Squiz.Commenting.VariableCommentsniff did not yet take this into account.This would result in a false positive
Missing member variable doc commenterror.Fixed now.