File::getMemberProperties(): minor tweaks after readonly merge #3515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/file-getmemberprops-minor-tweaks-for-readonly
branch
from
ee8ea84 to
5c8429d
Compare
|
Rebased to get past imaginary merge conflicts. @gsherwood As this is a follow-up on a PR which has gone into PHPCS 3.7.0 and updates the documentation for that change, can this still be merged in 3.7.0 ? |
Follow up on 3480 I realized after the merge that I had not published a few follow up comments. Addressing those here. * The new `is_readonly` key still needed to be added to the documentation for the `File::getMemberProperties()` method. * For consistency in how the method is tested, adding the `is_readonly` property to all other test expectations, which makes the `testPHP81NotReadonly` test case redundant. * Adding two additional test cases. In particular I wanted to verify (and safeguard) that the retokenization of the `?` to `T_NULLABLE` after a `readonly` keyword would not be broken (which it partially was, but that has now been fixed in 3513).
jrfnl
force-pushed
the
feature/file-getmemberprops-minor-tweaks-for-readonly
branch
from
5c8429d to
9d4c6d1
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #3480
I realized after the merge that I had not published a few follow up comments. Addressing those here.
is_readonlykey still needed to be added to the documentation for theFile::getMemberProperties()method.is_readonlyproperty to all other test expectations, which makes thetestPHP81NotReadonlytest case redundant.?toT_NULLABLEafter areadonlykeyword would not be broken (which it partially was, but that has now been fixed in PHP 8.1 | Tokenizer/PHP: readonly vs union types bug fix #3513).