Name of typed enum tokenized as T_GOTO_LABEL #3534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OTO_LABEL Follow up on 3478. When an `enum` would be backed by a type and the colon would directly follow the name of the `enum`, the name would be incorrectly tokenized (including the colon) as `T_GOTO_LABEL`. Discovered while reviewing 3482 Also related to 3161
jrfnl
force-pushed
the
php8.1/tokenizer-php-bugfix-enum-name-vs-goto-label
branch
from
5a2df66 to
bb03390
Compare
... after the bugfix for `T_GOTO_LABEL`. Also added a minor tweak to one test case to make sure that spacing around the type colon is handled correctly.
This was referenced Jan 18, 2022
Contributor
Author
|
@gsherwood Could this PR please be milestoned to 3.7.0 ? |
gsherwood
changed the title
Member
|
Thanks for finding and fixing this. |
jrfnl
deleted the
php8.1/tokenizer-php-bugfix-enum-name-vs-goto-label
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #3478.
When an
enumwould be backed by a type and the colon would directly follow the name of theenum, the name would be incorrectly tokenized (including the colon) asT_GOTO_LABEL.Discovered while reviewing #3482
Also related to #3161
/cc @kukulich
Tests/BackfillEnum: update token calculations
... after the bugfix for
T_GOTO_LABEL.Also added a minor tweak to one test case to make sure that spacing around the type colon is handled correctly.