Skip to content

Conversation

@kukulich
Copy link
Contributor

No description provided.

@kukulich kukulich mentioned this pull request Apr 22, 2022
8 tasks
@kukulich kukulich force-pushed the intersection branch 2 times, most recently from d6ccf09 to abf682b Compare April 22, 2022 10:12
@kukulich kukulich marked this pull request as ready for review April 22, 2022 10:16
@jrfnl
Copy link
Contributor

jrfnl commented Apr 30, 2022

FYI: I've not done a code review yet, but I have been running extensive tests with this branch and so far, I've not managed to break the implementation yet 🙌🏻 .

I'll post back with a full review once I've finished running tests and adding support in PHPCSUtils.

@gsherwood gsherwood added this to the 3.7.0 milestone May 17, 2022
@gsherwood gsherwood merged commit e4abe66 into squizlabs:master May 18, 2022
@gsherwood
Copy link
Member

Thanks a lot for this. All looked to work well.

@jrfnl
Copy link
Contributor

jrfnl commented May 18, 2022

Looks like the tests for the intersection types for the LowerCaseTypeSniff have disappeared during the rebase ? @kukulich Will you pull those separately ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants