Squiz/LowercasePHPFunctions + Generic/ForbiddenFunctions: bug fix for class names in attributes #3779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attributes cannot contain function calls and in most cases, `T_STRING`s in an attribute will be a class name, not a function name. As things were, `T_STRING`'s in attributes which _looked_ like function calls (but in actual fact are class instantiations) would lead to false positives. Fixed now by ignoring all code within attributes. Includes unit test. Fixes 3778
Attributes cannot contain function calls and in most cases, `T_STRING`s in an attribute will be a class name, not a function name. As things were, `T_STRING`'s in attributes which _looked_ like function calls (but in actual fact are class instantiations) would lead to false positives. Fixed now by ignoring all code within attributes. Includes unit test.
|
Note: there may be more sniffs which need adjusting for this, but these were the first ones which came to mind when I saw the bug report. |
|
FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release. As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squiz/LowercasePHPFunctions: bug fix for class names in attributes
Attributes cannot contain function calls and in most cases,
T_STRINGs in an attribute will be a class name, not a function name.As things were,
T_STRING's in attributes which looked like function calls (but in actual fact are class instantiations) would lead to false positives.Fixed now by ignoring all code within attributes.
Includes unit test.
Fixes #3778
Generic/ForbiddenFunctions: bug fix for class names in attributes
Attributes cannot contain function calls and in most cases,
T_STRINGs in an attribute will be a class name, not a function name.As things were,
T_STRING's in attributes which looked like function calls (but in actual fact are class instantiations) would lead to false positives.Fixed now by ignoring all code within attributes.
Includes unit test.