PSR12.Traits.UseDeclaration: check spacing after use keyword for multi-line statements + fix typo #3856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `processUseStatement()` method checking single-line trait `use` statements checks the spacing after the `use` keyword, but the error did not have the correct error code.
…lti-line statements While the `processUseStatement()` method checking single-line trait `use` statements would check the spacing after the `use` keyword, the `processUseGroup()` method checking multi-line trait `use` statements did not execute that same check, while the rule applies to both single- as well as multi-line `use` statements. By moving the check for the spacing after the `use` keyword to the `process()` method, it will now be executed for both situations. Tested by adjusting a pre-existing test.
5 tasks
|
Closing as replaced by PHPCSStandards/PHP_CodeSniffer#75 |
jrfnl
deleted the
feature/psr12-trait-use-fix-missing-keyword-spacing-check-multiline
branch
|
FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release. As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PSR12.Traits.UseDeclaration: fix typo in error code
The
processUseStatement()method checking single-line traitusestatements checks the spacing after theusekeyword, but the error did not have the correct error code.PSR12.Traits.UseDeclaration: check spacing after use keyword for multi-line statements
While the
processUseStatement()method checking single-line traitusestatements would check the spacing after theusekeyword, theprocessUseGroup()method checking multi-line traitusestatements did not execute that same check, while the rule applies to both single- as well as multi-lineusestatements.By moving the check for the spacing after the
usekeyword to theprocess()method, it will now be executed for both situations.Tested by adjusting a pre-existing test.
Suggested changelog entry
usekeyword using theSpaceAfterUseerrorcode.usekeyword for multi-line traitusestatements.Types of changes