reopen channel, retry publish #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2018 13:51
Signed-off-by: kuba-- <[email protected]>
Signed-off-by: kuba-- <[email protected]>
erizocosmico
approved these changes
Jun 20, 2018
amqp/amqp.go
Outdated
| } | ||
|
|
||
| b := &Broker{ | ||
| mut: sync.RWMutex{}, |
Contributor
There was a problem hiding this comment.
since mut is not a pointer the zero value is already sync.RWMutex{}, so you can remove this line
amqp/amqp_test.go
Outdated
| "github.com/stretchr/testify/suite" | ||
| ) | ||
|
|
||
| // Pilosa tests require running docker. If `docker ps` command returned an error |
Signed-off-by: kuba-- <[email protected]>
erizocosmico
approved these changes
Jun 20, 2018
Contributor
erizocosmico
left a comment
erizocosmico
left a comment
There was a problem hiding this comment.
LGTM when tests pass
jfontan
approved these changes
Jun 20, 2018
Author
|
Appveyor build failed (WHAT!?):
|
added 2 commits
June 20, 2018 22:51
Signed-off-by: kuba-- <[email protected]>
Signed-off-by: kuba-- <[email protected]>
Author
|
Ok, now we can merge. |
jfontan
suggested changes
Jun 21, 2018
amqp/amqp.go
Outdated
| break | ||
| } | ||
|
|
||
| // b.mut.Lock() |
Contributor
There was a problem hiding this comment.
Do we need those locks or can we delete the lines? Same in b.chErrors block.
Contributor
|
The AppVeyor problem with rabbit happens from time to time. There's already an issue opened to take a look. #10 |
Signed-off-by: kuba-- <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: src-d/borges#297
Publishif we connection dropped in a meantime.