build: i18n: Don't auto-download ICU unless --download=all #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of downloading ICU if missing from `deps/icu`, just print a warning unless either `--download=all` or `--download=icu` is set. Add some generic scaffolding in case other modules end up in the same boat in the future. It's harmless to pass `--download=xyzzy`, so, future proof (at least until some xyzzy dependency is integrated).
|
Sounds great. With my limited Python knowledge, LGTM. |
srl295
added a commit
that referenced
this pull request
Dec 18, 2014
build: i18n: Don't auto-download ICU unless --download=all Thanks @trevnorris for taking a look.
|
merged into my PR nodejs#8719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of downloading ICU if missing from
deps/icu, just print a warningunless either
--download=allor--download=icuis set.Add some generic scaffolding in case other modules end up in the same boat
in the future.
It's harmless to pass
--download=xyzzy, so, future proof(at least until some xyzzy dependency is integrated).
//cc: @tjfontaine @misterdjules @trevnorris - as per today's node.js sync call