Skip to content

PipeStream bug fixes #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

PipeStream bug fixes #1070

wants to merge 2 commits into from

Conversation

jorgensigvardsson
Copy link

  • Handle non-zero offsets in Read(byte[], int, int): trivial change - drop the non-zero check, and use the offset in the target buffer index.
  • Blocking bug: Don't block the pipe if available data is less than what's in the buffer. It may the case that the remote party is not sending, because it's waiting for data from us!

PipeStream bug fixes
67bcab1 
* Handle non-zero offsets in Read(byte[], int, int): trivial change - drop the non-zero check, and use the offset in the target buffer index.
* Blocking bug: Don't block the pipe if available data is less than what's in the buffer. It may the case that the remote party is not sending, because it's waiting for data from us!
@Rob-Hague Rob-Hague mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jorgensigvardsson