Skip to content

Changed Private Key Regex to be more tolerant regarding new lines at end of key file #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2024
Merged

Changed Private Key Regex to be more tolerant regarding new lines at end of key file #1344

merged 1 commit into from
Mar 6, 2024

Conversation

staecthSICKAG
Copy link
Contributor

@staecthSICKAG staecthSICKAG commented Mar 5, 2024 •
edited
Loading

SSH.NET so far threw an unhelpful error message regarding an invalid key file if there was a new line between the key data and the end line. The changed regex now allows zero or one empty line.

This is now allowed

...
dw+2Ggyq5W5hl3PDTMTqn8Pc+cwmPdVe4bkNqxbCHe2omZXpNIgC31wrMBvkyUYv
pY8rMoBXqgm9hC5JsXzn6Z6X1kpGFhDjkNSdzx4jYzw=

-----END RSA PRIVATE KEY-----

Rob-Hague
Rob-Hague approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@Rob-Hague Rob-Hague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, do you know how the key was generated?

WojciechNagorski
WojciechNagorski approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@WojciechNagorski WojciechNagorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WojciechNagorski WojciechNagorski merged commit 0876e88 into sshnet:develop Mar 6, 2024
@staecthSICKAG
Copy link
Contributor Author

Just curious, do you know how the key was generated?

Not really it was a key handed down to me from another department.
I would not discard the possibility that someone meddled with it to make it more aesthetically pleasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob-Hague Rob-Hague Rob-Hague approved these changes

@WojciechNagorski WojciechNagorski WojciechNagorski approved these changes

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staecthSICKAG @Rob-Hague @WojciechNagorski