Clean up Abstractions / use HashData #1451

mus65 · 2024-07-21T14:31:01Z

replace usages of GenerateRandom(byte[]) with GenerateRandom(int)
remove Create() functions and make use of static HashData methods on .NET 6+, see https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1850
Remove unused ReflectionAbstraction

- replace usages of GenerateRandom(byte[]) with GenerateRandom(int) - remove Create() functions and make use of static HashData methods on .NET 6+, see https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1850 - Remove unused ReflectionAbstraction

Rob-Hague · 2024-07-21T22:42:58Z

I wrote a very similar branch just the other day 🙂 develop...Rob-Hague:SSH.NET:hashoneshot

May I suggest taking the CryptoAbstraction.Hash[..] pattern from that branch. Seems like the ideal place for the ifdefs

Co-authored-by: Robert Hague <[email protected]>

mus65 · 2024-07-22T16:48:52Z

ha, bad timing. 😄

yeah, that's better, PrivateKeyFile.cs was kind of messy with all the ifdefs. I cherry-picked your changes and added you as co-auhor.

mus65 requested review from drieseng, WojciechNagorski and Rob-Hague as code owners July 21, 2024 14:31

Use Abstractions for HashData

1fa45a3

Co-authored-by: Robert Hague <[email protected]>

Rob-Hague approved these changes Jul 23, 2024

View reviewed changes

Rob-Hague merged commit 4cc1278 into sshnet:develop Jul 23, 2024

mus65 deleted the abstractioncleanup_hashdata branch September 14, 2024 09:30

Provide feedback