Allow deployment with manually installed TLS Secrets #227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the chart to allow cluster admins to deploy ServiceX with TLS-enabled Ingress by manually installing TLS Secrets containing certificates onto their cluster. This is an alternative to using cert-manager, and makes it optional where it was previously required.
Changes to the chart are as follows:
app.ingress.tlsapp.ingress.tls.enabledtotrue.app.ingress.tls.clusterIssuer(this is now empty by default).By default, the Ingress will look for a Secret named
<helm release name>-app-tls, but you can change this by settingapp.ingress.tls.secretName.A full config without cert-manager would look something like:
A full config with cert-manager would look like:
Partially addresses #222.